ViaVersion+ViaBackwards fix #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion and ViaBackwards provide it without, and the minecraft client uses the default `minecraft` namespace when deserializing the packet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try to get registry entry with and without minecraft namespace.
ViaVersion and ViaBackwards provide it without, and the minecraft client uses the default
minecraftnamespace when deserializing the packet, so it doesnt cause any issues, but replaymod does:dimension type tag: minecraft:dimension_type
dimension name: overworld
while ViaVersion/ViaBackwards provide:
dimension type tag: dimension_type
dimension name: minecraft:overworld
this does appear to be a viaversion issue, but since easier to fix it here, and not possibly disrupt other mods
vanilla:
viaversion: