Add journal field to unified search results #2913
Conversation
syqs
commented
Dec 10, 2025
syqs
commented
- Add external_source field to PaperDocument index
- Include external_source in search source fields (regular and DOI search)
- Map external_source to 'journal' field in API response
- Add journal field to DocumentResultSerializer
- Add external_source field to PaperDocument index - Include external_source in search source fields (regular and DOI search) - Map external_source to 'journal' field in API response - Add journal field to DocumentResultSerializer
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2913 +/- ##
==========================================
- Coverage 75.50% 75.39% -0.12%
==========================================
Files 529 533 +4
Lines 28840 29649 +809
==========================================
+ Hits 21776 22353 +577
- Misses 7064 7296 +232 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return None | ||
|
|
||
| for hub in hubs: | ||
| if not isinstance(hub, dict): |
There was a problem hiding this comment.
If a hub is defined would it ever be not a dict?
Generally, if types are wrong I'd rather the application fail with a warning
There was a problem hiding this comment.
yeah the hubs coming back from the opensearch are not AttrDict not regular dicts
…ects when author name is found in all 3 fields
…to avoid failing to index papers due to malformed author data
…ould require refactoring tests, changed author+title boost by 1 more, removed unused var
…tle boost value by 1
…dditionally removing cross_field_fallback_strategy since its adding alot of noise for not alot of relevant gain
|
