[#289] Flag to tag timeouts as permanent failure#290
Open
yevgenys wants to merge 1 commit intoRestComm:masterfrom
yevgenys:289_flag_to_tag_timeouts_as_permanent_failure
Open
[#289] Flag to tag timeouts as permanent failure#290yevgenys wants to merge 1 commit intoRestComm:masterfrom yevgenys:289_flag_to_tag_timeouts_as_permanent_failure
yevgenys wants to merge 1 commit intoRestComm:masterfrom
yevgenys:289_flag_to_tag_timeouts_as_permanent_failure
Conversation
…mmand; added new option to CLI get command; added tests for CLI get command; added new flag 'markTimeoutAsPermanentFailure' to SmscPropertiesManagement; added functionality for new flag;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactored SMSCShellExecutor:removed duplicates for CLI get command;
added new option to CLI get command;
added tests for CLI get command;
added new flag 'markTimeoutAsPermanentFailure' to SmscPropertiesManagement;
added functionality for new flag;
Fixes #289
reduced code in ShellExecutor;
added discovery of new getters via reflection:
no need to add manual call of getter method, getter will be discovered automatically
then just call function
addProperty(sb, "${getterNameWithout_get|is}");