Skip to content

Remove target-conditional properties #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
breyed wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove target-conditional properties #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions DotnetBridge/wwDotNetBridge.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- Compatible with .NET 4.72 through .NET 9 (and possibly later). Targets just net472 so that a single DLL can be used with all frameworks. -->
<TargetFramework>net472</TargetFramework>
<Version>8.1.4</Version>
<Authors>Rick Strahl</Authors>
Expand Down Expand Up @@ -29,17 +30,10 @@
<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
<DebugType>embedded</DebugType>
<GenerateDocumentationFile>true</GenerateDocumentationFile>

</PropertyGroup>
<PropertyGroup Condition="'$(TargetFramework)' != 'net472'">
<DefineConstants>NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
</PropertyGroup>
<PropertyGroup Condition=" '$(TargetFramework)' == 'net472'">
<DefineConstants>NETFULL</DefineConstants>
</PropertyGroup>

</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net472' ">
<ItemGroup>
Copy link

Copilot AI Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the condition from this ItemGroup means these .NET Framework references will now be included for all target frameworks. If this project ever targets non-.NET Framework versions in the future, these references may cause build errors or warnings since they're specific to .NET Framework.

Copilot uses AI. Check for mistakes.
<Reference Include="mscorlib" />
<Reference Include="System" />
<Reference Include="System.Core" />
Expand Down