Open
Conversation
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
michaelgruner
requested changes
Aug 12, 2025
|
|
||
| libsoup_dep = dependency('libsoup-3.0', version : '>=2.99', required: false) | ||
| if not libsoup_dep.found() | ||
| libsoup_dep = dependency('libsoup-2.4', version : '>=2.4') |
Contributor
There was a problem hiding this comment.
I think we should emulate autoconf's behavior here. If the user doesn't have libsoup3 or libsoup2 the last message they will see is meson asking them to install libsoup2, which we don't want. Mark it as required: false and handle it manually, so that we can message the user to prefer to install libsoup3
Contributor
There was a problem hiding this comment.
Also, if libsoup2 ends up being used, please output a warning saying that libsoup2 will be deprecated in incoming releases.
mmontero
requested changes
Aug 25, 2025
mmontero
approved these changes
Sep 5, 2025
kimberlycarvajal
force-pushed
the
feature/add-support-to-libsoup3
branch
from
e208394 to
98869ef
Compare
kimberlycarvajal
force-pushed
the
feature/add-support-to-libsoup3
branch
from
98869ef to
1124525
Compare
kimberlycarvajal
force-pushed
the
feature/add-support-to-libsoup3
branch
5 times, most recently
from
5d9c3cc to
41b3a57
Compare
kimberlycarvajal
force-pushed
the
feature/add-support-to-libsoup3
branch
from
41b3a57 to
6b547b2
Compare
kimberlycarvajal
force-pushed
the
feature/add-support-to-libsoup3
branch
4 times, most recently
from
9e38d37 to
30537ae
Compare
kimberlycarvajal
force-pushed
the
feature/add-support-to-libsoup3
branch
from
30537ae to
da5fe4c
Compare
kimberlycarvajal
force-pushed
the
feature/add-support-to-libsoup3
branch
from
e773492 to
c04a45f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for libsoup3 version.
If libsoup3 version is not found it looks for libsoup2.4 version.