fix: add type field to kv_store value parameter for llama.cpp compatibility#244
Open
mlzy wants to merge 1 commit intoRightNow-AI:mainfrom
Open
fix: add type field to kv_store value parameter for llama.cpp compatibility#244mlzy wants to merge 1 commit intoRightNow-AI:mainfrom
mlzy wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
The value property was missing a type field in its JSON schema definition. Added "type": "object" to properly declare the value type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"type": "object"to thevalueparameter inkv_storetool's JSON schema definitionFixes #236
Problem
llama.cpp's OpenAI-compatible backend fails when encountering tool parameters without an explicit
typefield. The error:JSON schema conversion failed: Unrecognized schema: {"description":"The JSON value to store (any type)"}
Solution
Add
"type": "object"to the value parameter schema, making it compatible with llama.cpp and other backends that require explicit typing.