Use SelectorEventLoop on Windows due to aiodns incompatibility with ProactorEventLoop#91
Draft
Nightriff wants to merge 2 commits intofix/dependency-installation-cleanupfrom
Conversation
…ox/roblox-blender-plugin into fix/aiodns-proactoreventloop-incompatibility
Collaborator
Author
|
Need to check if this works on windows, there are likely differences in the apis |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aiodns is incompatible with ProactorEventLoop in some cases, as noted on their readme.
The fix in this PR is to specify use of a SelectorEventLoop for windows users, as recommended by various issue threads on the topic.
This PR is being made in an attempt to fix #82