Add graph limit modal and SNS notification infrastructure#51
Merged
Conversation
…andling in deployment workflows - Introduced `notification_email` input for admin notifications in `deploy-app.yml`, `prod.yml`, and `staging.yml`. - Added logic to retrieve and pass the RoboSystems secret ARN in the CloudFormation template. - Implemented SNS topic and subscription for contact form notifications in the CloudFormation template. - Enhanced the NewGraphContent component to manage user graph creation limits and display a modal for contact requests when limits are reached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a graph provisioning limit flow that gates users when creating new graphs, along with supporting backend infrastructure for SNS email notifications and secret management. The feature adds a modal-based UI to inform users when they've reached their graph limit and provides a form to request limit increases.
Changes
Infrastructure & CI/CD
SNS_NOTIFICATION_EMAILparameter propagation throughdeploy-app.yml,prod.yml, andstaging.ymlworkflows to support email-based alertingROBOSYSTEMS_SECRET_ARNhandling in the deployment workflow for secure secret managementcloudformation/template.yamlwith ~79 lines of new resource definitions, likely including SNS topic/subscription resources and related IAM permissions for notification deliveryFrontend — Graph Limit Flow
GraphLimitModal.tsx(new): A modal component that surfaces when users hit their graph creation limit, providing clear feedback and a pathway to request increasesGraphLimitForm.tsx(new, 277 lines): A comprehensive form component for users to submit graph limit increase requests, likely including validation, form fields for justification, and submission handlinggraphs/new/content.tsx(modified): Integrated the new limit check logic into the graph creation flow, conditionally rendering the limit modal/form instead of or alongside the existing creation UI (~115 lines modified, net +91)Key UI/UX Improvements
Breaking Changes
SNS_NOTIFICATION_EMAILto be set in the workflow environment/secrets for prod and staging. Missing configuration may cause deployment failures.Testing Notes for Reviewers
ROBOSYSTEMS_SECRET_ARNis correctly resolved and accessible in the deployed environmentBrowser Compatibility Considerations
🤖 Generated with Claude Code
Branch Info:
feature/improved-graph-provisioning-flowmainCo-Authored-By: Claude noreply@anthropic.com