-
Notifications
You must be signed in to change notification settings - Fork 56
Bump macOS to Python 3.14 #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tyler-yankee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, +(status: not ready to merge) +(status: not ready for review)
Drake needs 3.14 wheels in order for this change to work.
Reviewable status: all discussions resolved, platform LGTM missing
tyler-yankee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, platform LGTM missing
a discussion (no related file):
Working
drake_poetry's pyproject.toml currently lists requires-python = ">=3.10,<3.14", because of the whole MOSEK requirements saga. I need to investigate (locally) whether we can just trivially bump to <3.15, or if the expanded version range is going to be incompatible with PyPI MOSEK. In the latter case, this PR might just be blocked on upstream?
|
FYI this is unblocked now that Drake v1.47.0 is out. |
f5313da to
48ffc92
Compare
tyler-yankee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-(status: not ready for review) +a:@BetsyMcPhail for feature review, please.
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @BetsyMcPhail)
BetsyMcPhail
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BetsyMcPhail reviewed 7 of 7 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, platform LGTM from [betsymcphail] (waiting on @tyler-yankee)
jwnimmer-tri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwnimmer-tri reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, platform LGTM from [betsymcphail, jwnimmer-tri] (waiting on @tyler-yankee)
-- commits line 4 at r2:
Please rebase, in which case I think this will no longer be true. (It's already been upgraded by the bot.)
48ffc92 to
2b700db
Compare
jwnimmer-tri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwnimmer-tri reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all discussions resolved, platform LGTM from [betsymcphail, jwnimmer-tri] (waiting on @tyler-yankee)
Also upgrade Drake to 1.47 so that 3.14 wheels are available.
Closes RobotLocomotion/drake#23592.
This change is