Skip to content

Conversation

@tyler-yankee
Copy link
Collaborator

@tyler-yankee tyler-yankee commented Nov 11, 2025

Also upgrade Drake to 1.47 so that 3.14 wheels are available.

Closes RobotLocomotion/drake#23592.


This change is Reviewable

Copy link
Collaborator Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, +(status: not ready to merge) +(status: not ready for review)

Drake needs 3.14 wheels in order for this change to work.

Reviewable status: all discussions resolved, platform LGTM missing

Copy link
Collaborator Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, platform LGTM missing


a discussion (no related file):
Working

drake_poetry's pyproject.toml currently lists requires-python = ">=3.10,<3.14", because of the whole MOSEK requirements saga. I need to investigate (locally) whether we can just trivially bump to <3.15, or if the expanded version range is going to be incompatible with PyPI MOSEK. In the latter case, this PR might just be blocked on upstream?

@jwnimmer-tri
Copy link
Contributor

FYI this is unblocked now that Drake v1.47.0 is out.

Copy link
Collaborator Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-(status: not ready for review) +a:@BetsyMcPhail for feature review, please.

Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @BetsyMcPhail)

Copy link
Contributor

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@BetsyMcPhail reviewed 7 of 7 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [betsymcphail] (waiting on @tyler-yankee)

Copy link
Contributor

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jwnimmer-tri reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, platform LGTM from [betsymcphail, jwnimmer-tri] (waiting on @tyler-yankee)


-- commits line 4 at r2:
Please rebase, in which case I think this will no longer be true. (It's already been upgraded by the bot.)

@jwnimmer-tri jwnimmer-tri self-assigned this Nov 19, 2025
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwnimmer-tri reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [betsymcphail, jwnimmer-tri] (waiting on @tyler-yankee)

@jwnimmer-tri jwnimmer-tri merged commit 5a80f9b into RobotLocomotion:main Nov 19, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.14 support

3 participants