Add RobotecFenceAssets/RobotecSurveillanceCameras Gems, Add assets to…#10
Merged
pawelbudziszewski merged 3 commits intomainfrom Sep 10, 2025
Merged
Add RobotecFenceAssets/RobotecSurveillanceCameras Gems, Add assets to…#10pawelbudziszewski merged 3 commits intomainfrom
pawelbudziszewski merged 3 commits intomainfrom
Conversation
… RobotecGenericDecorationsAssets, + RobotecFenceAssets Gem: Bollard01, Modular Fences + RobotecSurveillanceCameras Gem: CCTVCamera01, CCTVCamera02
Member
|
This PR is a derivative of RobotecAI/robotec-warehouse-assets#9 |
pawelbudziszewski
requested changes
Sep 9, 2025
Member
pawelbudziszewski
left a comment
There was a problem hiding this comment.
Everything looks and works fine. Some minor comments:
- If the fire extinguisher is not our in-house model, please add info to the NOTICE file
- Please bump
RobotecGenericDecorationsAssetsversion to2.0.0 - Please make sure that all textures are connected to the materials (or remove the texture file)
- Please move both CCTV cams so that the origin is in the mounting point
- Please make the collider for the extinguisher pipe a bit smaller:
...tecFencesAssets/Assets/ModularFences/Fences/Models/Materials/Textures/FenceWire_Rougness.png
Show resolved
Hide resolved
...Cameras/Assets/CCTVCameras/CCTVCamera01/Models/Materials/Textures/CCTVCamera01_Roughness.png
Show resolved
Hide resolved
...nceCameras/Assets/CCTVCameras/CCTVCamera02/Models/Materials/Textures/CCTVCamera02_Normal.png
Show resolved
Hide resolved
...Cameras/Assets/CCTVCameras/CCTVCamera02/Models/Materials/Textures/CCTVCamera02_Roughness.png
Show resolved
Hide resolved
- Fix CCTV cams origin - Fix CCTVs materials - change RobotecGenericDecorationsAssets to 2.0.0 - Update fire extinguisher collider
Member
|
Everything is ok now. |
Signed-off-by: Paweł Budziszewski <pawel.budziszewski@robotec.ai>
pawelbudziszewski
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… RobotecGenericDecorationsAssets,
Checklist Bollard01:
Checklist CCTVCameras:
Checklist ModularFences: