Feature/simple sensor simulator unit tests part3#29
Open
SzymonParapura wants to merge 7 commits intofeature/simple_sensor_simulator_unit_tests_part2from
Open
Conversation
- Added unit tests to DetectionSensor
- Added new line at the end of test_detection_sensor.hpp
robomic
requested changes
Jun 20, 2024
robomic
left a comment
robomic
left a comment
There was a problem hiding this comment.
please remove repeated functions if possible; in test_lidar_sensor.hpp and test_detection_sensor_hpp.
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.hpp
Outdated
Show resolved
Hide resolved
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.hpp
Outdated
Show resolved
Hide resolved
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.hpp
Outdated
Show resolved
Hide resolved
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.cpp
Outdated
Show resolved
Hide resolved
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.cpp
Outdated
Show resolved
Hide resolved
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.hpp
Outdated
Show resolved
Hide resolved
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.hpp
Outdated
Show resolved
Hide resolved
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.hpp
Outdated
Show resolved
Hide resolved
…feature/simple_sensor_simulator_unit_tests_part3
- Refactored DetectionSensor tests - Refactored LidarSensor tests
Author
|
I have refactored LidarSensor also... |
robomic
reviewed
Jun 24, 2024
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.cpp
Outdated
Show resolved
Hide resolved
- Refactored DetectionSensor tests
- Added unit tests to TrafficLightsDetector
- Refactored TrafficLightDetector unit tests
robomic
approved these changes
Jun 28, 2024
...imple_sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor.hpp
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Abstract
This PR contains unit tests for:
Details
References
Jira ticket: link
Destructive Changes
There are no destructive changes