Open
Conversation
robomic
requested changes
Aug 16, 2024
simulation/traffic_simulator/include/traffic_simulator/behavior/behavior_plugin_base.hpp
Show resolved
Hide resolved
simulation/traffic_simulator/test/src/data_type/test_lanelet_pose.cpp
Outdated
Show resolved
Hide resolved
simulation/traffic_simulator/test/src/data_type/test_lanelet_pose.cpp
Outdated
Show resolved
Hide resolved
simulation/traffic_simulator/test/src/data_type/test_lanelet_pose.cpp
Outdated
Show resolved
Hide resolved
simulation/traffic_simulator/test/src/data_type/test_lanelet_pose.cpp
Outdated
Show resolved
Hide resolved
simulation/traffic_simulator/test/src/data_type/test_lanelet_pose.cpp
Outdated
Show resolved
Hide resolved
simulation/traffic_simulator/test/src/data_type/test_lanelet_pose.cpp
Outdated
Show resolved
Hide resolved
simulation/traffic_simulator/test/src/data_type/test_lanelet_pose.cpp
Outdated
Show resolved
Hide resolved
robomic
reviewed
Aug 16, 2024
gmajrobotec
force-pushed
the
feature/unit_tests/canonicalized_lanelet_pose
branch
from
eb94b6e to
9903a3a
Compare
robomic
approved these changes
Sep 3, 2024
robomic
left a comment
robomic
left a comment
There was a problem hiding this comment.
LGTM, just add this one minor change
simulation/traffic_simulator/test/src/data_type/test_lanelet_pose.cpp
Outdated
Show resolved
Hide resolved
simulation/traffic_simulator/test/src/data_type/test_lanelet_pose.cpp
Outdated
Show resolved
Hide resolved
simulation/traffic_simulator/test/src/data_type/test_lanelet_pose.cpp
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Abstract
This PR contains unit tests for CanonicalizedLaneletPose class, which is a part of traffic_simulator package
Details
List of tests included in this PR:
References
Jira ticket: internal link
Destructive Changes
There are no destructive changes.