Skip to content

chore: Fixes Some Terminology to Avoid Confusion. #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Spiral-Memory wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: Fixes Some Terminology to Avoid Confusion. #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a267463
fixed some terminology to avoid confusion
Spiral-Memory Feb 2, 2024
25109b1
added help message to for notion view command
Spiral-Memory Feb 2, 2024
1acd7c5
changed subpage text back to page
Spiral-Memory Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion enum/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ export enum Messages {
• use \`/notion create\` to create page or record
• use \`/notion create db\` to create database
• use \`/notion workspace\` to change workspace
• use \`/notion share\` to share pages
• use \`/notion share\` to share pages
• use \`/notion view\` to view database content

`,
HELPER_TEXT = `Need some help with \`/notion\`?`,
Expand Down
6 changes: 3 additions & 3 deletions enum/modals/NotionPageOrRecord.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ export enum NotionPageOrRecord {
CLOSE = "Close",
CLOSE_ACTION = "close-page-or-record-action-id",
CLOSE_BLOCK = "close-page-or-record-block-id",
TITLE_PLACEHOLDER = "Enter Title of Page or Record",
TITLE_PLACEHOLDER = "Enter Title of Page",
TITLE_LABEL = "Title *",
TITLE_BLOCK = "title-page-or-record-block-id",
TITLE_ACTION = "title-page-or-record-action-id",
CHANGE_DATABASE_TEXT = "Change Database",
CHANGE_DATABASE_ACTION = "create-page-or-record-change-database-action-id",
CHANGE_SELECTION_TEXT = "Change Selection",
CHANGE_SELECTION_ACTION = "create-page-or-record-change-selection-action-id",
PROPERTY_SELECTED_BLOCK_ELEMENT = "property-selected-element-create-page-or-record-block-id",
OVERFLOW_CHANGE_TO_PAGE_ACTION = "create-notion-page-overflow-menu-action-id",
OVERFLOW_CHANGE_TO_PAGE_TEXT = "Create Page or Record",
Expand Down
4 changes: 2 additions & 2 deletions src/handlers/ExecuteBlockActionHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@ export class ExecuteBlockActionHandler {
const OverFlowActions = [
DatabaseModal.OVERFLOW_CHANGE_WORKSPACE_ACTION.toString(),
DatabaseModal.OVERFLOW_MENU_ACTION_CREATE_DB.toString(),
NotionPageOrRecord.CHANGE_DATABASE_ACTION.toString(),
NotionPageOrRecord.CHANGE_SELECTION_ACTION.toString(),
NotionPageOrRecord.OVERFLOW_CHANGE_TO_PAGE_ACTION.toString(),
];

Expand Down Expand Up @@ -847,7 +847,7 @@ export class ExecuteBlockActionHandler {
break;
}

case NotionPageOrRecord.CHANGE_DATABASE_ACTION: {
case NotionPageOrRecord.CHANGE_SELECTION_ACTION: {
await handler.createNotionPageOrRecord(true);
break;
}
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/ExecuteViewSubmitHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ export class ExecuteViewSubmitHandler {
];
const { fields, url, pageId } = createdRecord;

message = `Created [**${title}**](${url}) in [**${databasename}**](${databaselink})`;
message = `Created a new record with title [**${title}**](${url}) in the database [**${databasename}**](${databaselink})`;

const messageId = await sendMessageWithAttachments(
this.read,
Expand Down
4 changes: 2 additions & 2 deletions src/modals/createPageOrRecordModal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ export async function createPageOrRecordModal(

if (parent) {
overFlowMenuText.unshift(
NotionPageOrRecord.CHANGE_DATABASE_TEXT.toString()
NotionPageOrRecord.CHANGE_SELECTION_TEXT.toString()
);
overFlowMenuValue.unshift(
NotionPageOrRecord.CHANGE_DATABASE_ACTION.toString()
NotionPageOrRecord.CHANGE_SELECTION_ACTION.toString()
);
}

Expand Down