Skip to content

Fix quote markdown#676

Closed
devanshkansagra wants to merge 6 commits intoRocketChat:developfrom
devanshkansagra:fix-quote-markdown
Closed

Fix quote markdown#676
devanshkansagra wants to merge 6 commits intoRocketChat:developfrom
devanshkansagra:fix-quote-markdown

Conversation

@devanshkansagra
Copy link
Contributor

@devanshkansagra devanshkansagra commented Dec 1, 2024

Fixed the quote markdown issue

Acceptance Criteria fulfillment

Now if you enter the message like this it won't create any issue

> I will not use abbrev.
>
> I will not use abbrev.
>
> I will not use abbrev.

Fixes #675

Video/Screenshots

image

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-676 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

Hi @devanshkansagra
I didn't really understand the issue, can you take some to explain it once.

@devanshkansagra
Copy link
Contributor Author

check this issue https://github.com/RocketChat/Rocket.Chat/issues/33493

Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to test

@devanshkansagra
Copy link
Contributor Author

Not this one, the multiple quoting one and recursive quoting one

@devanshkansagra
Copy link
Contributor Author

#641

@Spiral-Memory
Copy link
Collaborator

Hi @devanshkansagra,

Blockquotes are typically used to highlight important notes or text. It would be better if you add a line as well. Additionally, blockquotes should support nesting.

Here’s an example for you. This will be rendered properly by GitHub:

> Hello  
> This is a blockquote.  
>> This is a nested blockquote.  

Hii

Hello
This is a blockquote.

This is a nested blockquote.

Hi

@devanshkansagra
Copy link
Contributor Author

Okay, will work on this highlighting and nesting the quotes

@devanshkansagra
Copy link
Contributor Author

devanshkansagra commented Dec 15, 2024

Hey, can we implement this highlight thing by implementing a button in chatinput toolbar and on highlighting...users will able to highlight the thing they want to, if yes then I will add this addition in this pr

@Spiral-Memory
Copy link
Collaborator

Hey, can we implement this highlight thing by implementing a button in chatinput toolbar and on highlighting...users will able to highlight the thing they want to, if yes then I will add this addition in this pr

Not needed @devanshkansagra

@devanshkansagra
Copy link
Contributor Author

okk

@Spiral-Memory
Copy link
Collaborator

Let me know, once this is ready to review

@devanshkansagra
Copy link
Contributor Author

Hey @Spiral-Memory, it is not currently ready for review and also I am not currently working on this as I am busy in some other important stuffs which are even more important than this, Keep it open or I will draft it, I will make it ready for review when I will push the commit to this repo

@Spiral-Memory
Copy link
Collaborator

No no, I'm saying can you a show a video of how it's implemented on rc.. and how it can be useful for ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: BlockQuote Markdown is not rendering properly

2 participants