Conversation
|
Hi @devanshkansagra |
|
check this issue |
Spiral-Memory
left a comment
There was a problem hiding this comment.
Approving to test
|
Not this one, the multiple quoting one and recursive quoting one |
|
|
|
Hi @devanshkansagra, Blockquotes are typically used to highlight important notes or text. It would be better if you add a line as well. Additionally, blockquotes should support nesting. Here’s an example for you. This will be rendered properly by GitHub: > Hello
> This is a blockquote.
>> This is a nested blockquote.
Hii
Hi |
|
Okay, will work on this highlighting and nesting the quotes |
|
Hey, can we implement this highlight thing by implementing a button in chatinput toolbar and on highlighting...users will able to highlight the thing they want to, if yes then I will add this addition in this pr |
82cb887 to
6cd93da
Compare
Not needed @devanshkansagra |
|
okk |
|
Let me know, once this is ready to review |
|
Hey @Spiral-Memory, it is not currently ready for review and also I am not currently working on this as I am busy in some other important stuffs which are even more important than this, Keep it open or I will draft it, I will make it ready for review when I will push the commit to this repo |
|
No no, I'm saying can you a show a video of how it's implemented on rc.. and how it can be useful for ec |
2ef2985 to
8f3bb40
Compare
Fixed the quote markdown issue
Acceptance Criteria fulfillment
Now if you enter the message like this it won't create any issue
Fixes #675
Video/Screenshots
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-676 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.