FEAT: Added draft-saving feature for messages, which automatically sends them when the internet is restored.#722
Closed
dhairyashiil wants to merge 5 commits intoRocketChat:developfrom
Conversation
…red and some validations
Collaborator
|
Woah, this looks like a huge PR, i'll need some time to review this |
Contributor
Author
No problem! Take your time, and let me know if you need anything. Welcome! :) |
Collaborator
|
Hi @dhairyashiil |
Contributor
Author
|
Hello @Spiral-Memory, I have removed the toast message logic as you suggested. Currently, if the user is offline, they can still see their messages on the screen due to the upsert message functionality. Also, WhatsApp shows messages with a circle tick in the bottom-right corner. Do you think I should implement that too? |
Collaborator
|
Yes |
dhairyashiil
commented
Jan 12, 2025
Contributor
Author
Okay, I will work on it |
2ef2985 to
8f3bb40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Title
Added draft-saving feature for messages, which automatically sends them when the internet is restored.
Acceptance Criteria fulfillment
Also added the following:
Fixes #721
Video/Screenshots
In the above video, I have not shown a demo for the video messages but that too works as expected.
Upsert message functionality for file messages (consistent UI).
(To see the upsert message functionality for audio messages, refer to the demo video above.)
6.upserting.message.mp4
Validation for File Messages.
4.file.message.mp4
Validation for Edit Messages.
5.edit.message.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-722 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.