Skip to content

feat: Added a conditional check before showing Avatar in attachments#788

Closed
thepiyush-303 wants to merge 3 commits intoRocketChat:developfrom
thepiyush-303:hideAvatarInAttachments
Closed

feat: Added a conditional check before showing Avatar in attachments#788
thepiyush-303 wants to merge 3 commits intoRocketChat:developfrom
thepiyush-303:hideAvatarInAttachments

Conversation

@thepiyush-303
Copy link
Contributor

@thepiyush-303 thepiyush-303 commented Jan 3, 2025

Brief Title

Acceptance Criteria fulfillment

  • Now when avatar is set to false inside addons then attached items's docs not show avatar

Fixes #787

Video/Screenshots

Screencast.from.2025-01-04.01-05-18.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-788 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@abirc8010
Copy link
Contributor

abirc8010 commented Jan 3, 2025

Hey @thepiyush-303,
I noticed that the video you uploaded might not correspond to the changes in this PR. Could you update the PR description with:

  1. A highlight of the changes made.
  2. The correct video showcasing the implemented fixes.
  3. Also link your PR with the issue

@thepiyush-303
Copy link
Contributor Author

Hey @thepiyush-303, I noticed that the video you uploaded might not correspond to the changes in this PR. Could you update the PR description with:

1. A highlight of the changes made.

2. The correct video showcasing the implemented fixes.

3. Also link your PR with the issue

Thanks, @abirc8010 for letting me know it was showing now i update it.
also i see a minor css issue i'll commit it soon

@thepiyush-303 thepiyush-303 changed the title Added a conditional check before showing Avatar in attachments feat: Added a conditional check before showing Avatar in attachments Jan 4, 2025
@Spiral-Memory
Copy link
Collaborator

Update the video, i can see some text overlaps

@thepiyush-303
Copy link
Contributor Author

@Spiral-Memory
It is fixed in my last commit.

Screencast.from.2025-01-28.00-10-45.mp4

@thepiyush-303 thepiyush-303 marked this pull request as draft February 6, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UserIcon does not hide if showAvatar addon is set to false

3 participants