feat: Added a conditional check before showing Avatar in attachments#788
Closed
thepiyush-303 wants to merge 3 commits intoRocketChat:developfrom
Closed
feat: Added a conditional check before showing Avatar in attachments#788thepiyush-303 wants to merge 3 commits intoRocketChat:developfrom
thepiyush-303 wants to merge 3 commits intoRocketChat:developfrom
Conversation
Contributor
|
Hey @thepiyush-303,
|
Contributor
Author
Thanks, @abirc8010 for letting me know it was showing now i update it. |
2ef2985 to
8f3bb40
Compare
Collaborator
|
Update the video, i can see some text overlaps |
Contributor
Author
|
@Spiral-Memory Screencast.from.2025-01-28.00-10-45.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Title
Acceptance Criteria fulfillment
Fixes #787
Video/Screenshots
Screencast.from.2025-01-04.01-05-18.webm
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-788 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.