feat: Add Unpin and Unstar message functionality to the icons in Message Headers#796
Conversation
…ageHeader component
|
Hey @AyushKumar123456789 I think this is already covered in this PR #744 |
|
Yes sir, but my implementation was different keeping in mind that embedded chat is itself nested in some other components, So in my opinion implementation of toolbox menu might increase unnecessary complexity which is that PR. |
I'm not quite sure how this would complicate the embedded experience. Let @Spiral-Memory share his thoughts. Also you can call me Abir no need of "Sir" 🙂 |
|
Thank you for input Abir, Maybe you were right about ,
If that the case you can close the PR, I also made another PR #776 , can you please give me feedback on that |
|
Hey @AyushKumar123456789 Thanks |
Brief Title
Acceptance Criteria fulfillment
Fixes #741
In this PR, I’ve opted for a simpler approach: users can unpin or unstar a file directly by clicking the existing icons. This preserves a clean interface within EmbeddedChat, which is often nested in other applications. Adding a separate “Copy Link” or extra menu might complicate the embedded experience.
Video/Screenshots
unpin.and.unstar.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace
<pr_number>with the actual PR number.