Skip to content

Fix : Threaded Messages Sorting Based on Latest Reply Time.#805

Closed
AyushKumar123456789 wants to merge 6 commits intoRocketChat:developfrom
AyushKumar123456789:fix-Threaded_message_sorted_based_on_latest_reply
Closed

Fix : Threaded Messages Sorting Based on Latest Reply Time.#805
AyushKumar123456789 wants to merge 6 commits intoRocketChat:developfrom
AyushKumar123456789:fix-Threaded_message_sorted_based_on_latest_reply

Conversation

@AyushKumar123456789
Copy link
Contributor

Brief Title

Fix Threaded Messages Sorting Based on Latest Reply Time.

Acceptance Criteria fulfillment

  • Implemented sorting of threaded messages based on the latest reply time (tlm).

Fixes #804

Video/Screenshots

fixed.threaded.message.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

@AyushKumar123456789
Pls fix lint error

@AyushKumar123456789
Copy link
Contributor Author

AyushKumar123456789 commented Jan 5, 2025

Sir, I have fixed the linting, Can you please try to merge it again.
If it still faces some issues , pardon me for that
but I have tried my best to make the merge successful.

@Spiral-Memory
Copy link
Collaborator

It doesn't already come in sorted order from RC ?

It would not be good to sort on frontend i beleive

@AyushKumar123456789
Copy link
Contributor Author

Thanks for the feedback. Rocket.Chat currently sorts threads based on when they were started, not by the latest replies. To improve the user experience, I implemented frontend sorting to display the most recent replies first. I agree that backend sorting would be more efficient and will look into enhancing it accordingly.

@Spiral-Memory
Copy link
Collaborator

In that case @AyushKumar123456789
Let's follow the rocket.chat behaviour and let's not sort things on the frontend..

We may look for other possibilities later on,
Thanks a lot for your interest and contribution..

I'm closing this PR due to mentioned reasons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug : Message in the thread section is not sorted based on recent reply like in rocket chat.

2 participants