feat: Enhance add link modal and disabling message items while typing#809
feat: Enhance add link modal and disabling message items while typing#809thepiyush-303 wants to merge 23 commits intoRocketChat:developfrom
Conversation
|
Please attach a video/screenshot of the Add Link modal as well. |
It's already shown in the screencast attached above |
Got it. Can we remove the placeholders? Since you added labels, users will know what to type inside them. Regarding the labels, since it's a Link Window and we're only interacting with the link (not any other functionality), users will understand that the 'Text' and 'URL' refer to the link. There's no need to specifically label them as 'Link Text' and 'Link URL'. Also, I think it would be nice to stay consistent with Rocket.Chat channel terminology, using only 'Text' and 'URL'. |
|
Got it! |
2ef2985 to
8f3bb40
Compare
|
Resolve conflicts |
|
Done. |
53e3f78 to
407d8b6
Compare
|
Hello @Spiral-Memory |
Brief Title
Enhance add link modal including proper css making it more user friendly, and when we write something it should disable items such as Audio recorder, video recorder and upload file option.
Acceptance Criteria fulfillment
Fixes #808
Video/Screenshots
Screencast.from.2025-02-08.09-23-19.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-809 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.