chore/feat: Add tooltip displaying users who reacted with a particular emoji#820
Merged
Spiral-Memory merged 11 commits intoRocketChat:developfrom Feb 9, 2025
Merged
Conversation
Collaborator
|
Hey @abirc8010 |
| const styles = getMessageReactionsStyles(theme); | ||
| const [hoveredReaction, setHoveredReaction] = useState(null); | ||
| const tooltipMap = {}; | ||
| const getTooltipContent = (reaction) => { |
Collaborator
There was a problem hiding this comment.
This much manual computation are required ? Do we have an easy way of implementing this ?
The reason i am saying this, using function like splice etc throw an error if there are empty things and all.. So a bit concerned about the stablity..
Can we look for a method with less computation involved
Contributor
Author
There was a problem hiding this comment.
Hey @Spiral-Memory I have updated my approach
Spiral-Memory
force-pushed
the
develop
branch
from
2ef2985 to
8f3bb40
Compare
Spiral-Memory
approved these changes
Jan 30, 2025
Spiral-Memory
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Title
This PR introduces a tooltip displaying users who reacted with a specific emoji.
Acceptance Criteria fulfillment
hoveredReactionto track the currently hovered reaction.tooltipMapto store the tooltip content for each reaction.getTooltipContentto generate a string of users who reacted,Fixes #819
Video/Screenshots
Screencast.from.2025-01-06.22-44-53.webm
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-820 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.