Skip to content

feat: Add file size in attached docs and Tooltips for downloads/collapse/title options.#829

Merged
Spiral-Memory merged 11 commits intoRocketChat:developfrom
thepiyush-303:feat/addFileSize
Feb 9, 2025
Merged

feat: Add file size in attached docs and Tooltips for downloads/collapse/title options.#829
Spiral-Memory merged 11 commits intoRocketChat:developfrom
thepiyush-303:feat/addFileSize

Conversation

@thepiyush-303
Copy link
Contributor

@thepiyush-303 thepiyush-303 commented Jan 7, 2025

Brief Title

Added file size display for all attachment types and tooltips for download, collapse, and other options. Also fixed a responsiveness issue where the image title overlapped on smaller screens—now it truncates with an ellipsis, and the full title can be viewed via a tooltip.

Acceptance Criteria fulfillment

  • file-size should be shown beside the image title.
  • ToolTips should be shown for title/download/collapse button.
  • overlapping of file-name also fixed by adding elippses.
  • responsiveness of all type of attachments

Fixes #779

Video/Screenshots

Both Before and After is shown in this clip.

Screencast.from.2025-01-07.23-31-18.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-829 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spiral-Memory
Copy link
Collaborator

THis change is only valid in Pinned messages ?

@Spiral-Memory
Copy link
Collaborator

image

Tooltip is too far away

@Spiral-Memory
Copy link
Collaborator

image

Can't see this change in File sidebar ? any reason ?

@Spiral-Memory Spiral-Memory added the question Further information is requested label Jan 27, 2025
@thepiyush-303
Copy link
Contributor Author

Can't see this change in File sidebar ? any reason ?

Since RC doesn't show file size in file Sidebar so, I haven't add it in file Sidebar.

@thepiyush-303
Copy link
Contributor Author

thepiyush-303 commented Jan 27, 2025

THis change is only valid in Pinned messages ?

no it is for all file messages.

@thepiyush-303
Copy link
Contributor Author

image

Tooltip is too far away

@Spiral-Memory
It is because ActionButton is having inbuilt margin from the top, like when you see input formatting toolbar you will notice there also tooltip is far away, if there is anything i can do for it please let me know

@thepiyush-303
Copy link
Contributor Author

thepiyush-303 commented Feb 3, 2025

@Spiral-Memory

I want to add some more changes for responsiveness of the Metadata
can I add in this PR Now?

@thepiyush-303 thepiyush-303 marked this pull request as draft February 3, 2025 19:35
@thepiyush-303
Copy link
Contributor Author

thepiyush-303 commented Feb 6, 2025

also fixed some responsive issues the video of issue is attached in issue:
this is the final change ->

Screencast-from-2025-02-07-00-40-24.mp4

@thepiyush-303 thepiyush-303 marked this pull request as ready for review February 6, 2025 19:21
@Spiral-Memory Spiral-Memory merged commit b03c0b7 into RocketChat:develop Feb 9, 2025
3 checks passed
@Spiral-Memory Spiral-Memory added chore a subtle fix and removed question Further information is requested testing labels Feb 9, 2025
github-actions bot added a commit that referenced this pull request Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a subtle fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attached docs not showing size of that file add ToolTips for downloads and Collapse buttons.

2 participants