feat: Add file size in attached docs and Tooltips for downloads/collapse/title options.#829
Merged
Spiral-Memory merged 11 commits intoRocketChat:developfrom Feb 9, 2025
Merged
Conversation
2ef2985 to
8f3bb40
Compare
Collaborator
|
THis change is only valid in Pinned messages ? |
Collaborator
Collaborator
Contributor
Author
Since RC doesn't show file size in file Sidebar so, I haven't add it in file Sidebar. |
Contributor
Author
no it is for all file messages. |
Contributor
Author
@Spiral-Memory |
Contributor
Author
|
I want to add some more changes for responsiveness of the Metadata |
Contributor
Author
|
also fixed some responsive issues the video of issue is attached in issue: Screencast-from-2025-02-07-00-40-24.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Brief Title
Added file size display for all attachment types and tooltips for download, collapse, and other options. Also fixed a responsiveness issue where the image title overlapped on smaller screens—now it truncates with an ellipsis, and the full title can be viewed via a tooltip.
Acceptance Criteria fulfillment
Fixes #779
Video/Screenshots
Both Before and After is shown in this clip.
Screencast.from.2025-01-07.23-31-18.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-829 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.