Fix: Ensure deleted messages are removed from starred and pinned message sidebars#862
Closed
smritidoneria wants to merge 3 commits intoRocketChat:developfrom
Closed
Fix: Ensure deleted messages are removed from starred and pinned message sidebars#862smritidoneria wants to merge 3 commits intoRocketChat:developfrom
smritidoneria wants to merge 3 commits intoRocketChat:developfrom
Conversation
Contributor
Author
|
Hi @Spiral-Memory, could you kindly review PR #854 ? The issue addressed in this PR cannot be fully resolved unless PR #854 is merged. |
Spiral-Memory
force-pushed
the
develop
branch
from
2ef2985 to
8f3bb40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Title
This pull request addresses the issue where messages deleted from the main chat interface do not get removed from the starred messages sidebar modal and the pinned messages sidebar modal. The solution involves updating the state for starred and pinned messages in real-time when a message is deleted from the main chat interface.
Fixes #861
Video/Screenshots
Screen.Recording.2025-01-10.at.11.17.55.AM.mov
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace
<pr_number>with the actual PR number.