feat: Add timeStamps in attached text#875
Closed
thepiyush-303 wants to merge 14 commits intoRocketChat:developfrom
Closed
feat: Add timeStamps in attached text#875thepiyush-303 wants to merge 14 commits intoRocketChat:developfrom
thepiyush-303 wants to merge 14 commits intoRocketChat:developfrom
Conversation
2ef2985 to
8f3bb40
Compare
Collaborator
|
In EC, the choice between username or name is customizable: You will have to make it dynamic : Remove @ sign from attachment because RC also doesn't include it. |
Contributor
Author
|
@Spiral-Memory any other changes? |
Contributor
Author
|
(same video as above) Screencast.from.2025-02-06.21-39-15.mp4Hey @Spiral-Memory,
It is inspired by the approach that RC follows, i implement it and found some responsive issues so i also fixed them, check final changes is video. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Brief Title
Now text attachments also include timeStamps beside username just like RC
I have added timestamp in the following way:
It is inspired by the approach that RC follows, i implement it and found some responsive issues so i also fixed them, check final changes is video.
Acceptance Criteria fulfillment
Fixes #873
Video/Screenshots
Screencast.from.2025-02-06.21-39-15.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-875 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.