Feat: highlight search messages#884
Closed
dhairyashiil wants to merge 5 commits intoRocketChat:developfrom
Closed
Conversation
Spiral-Memory
force-pushed
the
develop
branch
from
2ef2985 to
8f3bb40
Compare
|
|
||
| export const useHighlightTextStyles = { | ||
| highlight: css` | ||
| background-color: yellow; |
Collaborator
There was a problem hiding this comment.
Don't use hardcoded colors
Contributor
Author
There was a problem hiding this comment.
Okay, sorry about this. I forgot to set the color according to the mode and theme.
Collaborator
|
This is a great PR. I think, you can optimize it further, Look into it, if you can reduce the amount of changes for this Thanks |
Contributor
Author
Thank you for the appreciation. I'm happy you liked it 😁, and yes, I will look into how I can optimize it further |
Collaborator
|
Have a look at this PR : #937 She has done it in quite a few lines, though you've to see the optimization + stability |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Title
Highlight searched message text in rendered messages in Sidebar
Acceptance Criteria fulfillment
Fixes #883
Video/Screenshots:
highlight.searched.messages.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-884 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.