Skip to content

fix: correct UI for archived channels and display channel topic#905

Merged
Spiral-Memory merged 5 commits intoRocketChat:developfrom
SinghaAnirban005:archive-room
May 24, 2025
Merged

fix: correct UI for archived channels and display channel topic#905
Spiral-Memory merged 5 commits intoRocketChat:developfrom
SinghaAnirban005:archive-room

Conversation

@SinghaAnirban005
Copy link
Contributor

@SinghaAnirban005 SinghaAnirban005 commented Jan 15, 2025

Brief Title

Fix UI for Archived Channels and handle Long Channel Topic in EmbeddedChat

Acceptance Criteria fulfillment

  • Ensure the chat UI updates to reflect the archived state of channels.
  • Display the channel topic below the channel name when long using ellipsis
  • Create an endpoint that retrieves room Info after room has been archived

Fixes #880

Video/Screenshots

general.-.Singha.-.Brave.2025-01-15.16-04-41.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-905 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

Can we also have the yellow (warning) border along that Room archived message, Make sure it aligns with all themes

Rest LGTM

@SinghaAnirban005
Copy link
Contributor Author

After changes

EmbeddedChat._.Simple.-.Simple.Storybook.-.Google.Chrome.2025-01-28.22-32-48.mp4

Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spiral-Memory Spiral-Memory merged commit 6b6340a into RocketChat:develop May 24, 2025
4 checks passed
github-actions bot added a commit that referenced this pull request May 24, 2025
@Spiral-Memory
Copy link
Collaborator

Spiral-Memory commented May 24, 2025

Hii @SinghaAnirban005 @abirc8010 @devanshkansagra
I think the test channel is not archived but is still showing archived, if you guys get some time, Please fix that :
image

@Spiral-Memory Spiral-Memory added the discussion Requires team discussion before proceeding. label May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discussion Requires team discussion before proceeding.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Channel Archiving Issues: UI Not Updating and Missing Topic in Chat Body Header

2 participants