Improved file attachment window for formats like pdfs etc. #925
Closed
thepiyush-303 wants to merge 1 commit intoRocketChat:developfrom
Closed
Improved file attachment window for formats like pdfs etc. #925thepiyush-303 wants to merge 1 commit intoRocketChat:developfrom
thepiyush-303 wants to merge 1 commit intoRocketChat:developfrom
Conversation
Contributor
|
Hello @thepiyush-303, I think Anirban has already implemented it in his open PR #836. Can you please confirm, @SinghaAnirban005? I'm not sure. please check. |
Contributor
|
Ahh yes @thepiyush-303 , #836 addresses the changes you have made here and is already approved. You may close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Title
Fixes #924
Previously:
Video/Screenshots
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace
<pr_number>with the actual PR number.