fix:File attachement UI#953
Closed
AyushKumar123456789 wants to merge 3 commits intoRocketChat:developfrom
Closed
Conversation
…overlap for file/audio attachments
Contributor
|
Hey @AyushKumar123456789 could you not implement "A collapse/expand button has been added for file attachments." because i had already raised a PR specific to it #836 and it has been approved |
Collaborator
|
Let me know once the @SinghaAnirban005 feedback is implemented |
Contributor
Author
|
Sir, I have made the necessary changes as pointed out by @SinghaAnirban005. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix UI issues for file and audio attachments
Acceptance Criteria fulfillment
Fixes #952
Video/Screenshots
Previously :
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-953 after approval.