fix: UI Jumps When Hovering Over Last Message's MessageToolbox Options#971
Closed
Abbas-Askari wants to merge 1 commit intoRocketChat:developfrom
Closed
fix: UI Jumps When Hovering Over Last Message's MessageToolbox Options#971Abbas-Askari wants to merge 1 commit intoRocketChat:developfrom
Abbas-Askari wants to merge 1 commit intoRocketChat:developfrom
Conversation
Contributor
|
Hey @Abbas-Askari , I have made a PR #901 on it and currently working on it. And the given solution is not appropriate as the tooltip would be covered by message header on top. |
Author
|
I can't overlap with the header because there is padding at the top of the messageList. |
Contributor
|
hey @Abbas-Askari! Its good idea to collaborate. Lets make the tooltip position dynamic. |
Collaborator
|
Refer me to the final PR once implemented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #970 By moving
MessageToolbox's button's tooltips to top instead of bottom. This is consistent with the Main Rocket Chat's tooltips.Video/Screenshots
New:
Tooltips in main Rocket Chat are also at the top:
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-971 after approval.