i18n: Rocket.Chat language update from Lingohub 🤖 on 2026-03-02Z#39242
Open
lingohub[bot] wants to merge 1 commit intodevelopfrom
Open
i18n: Rocket.Chat language update from Lingohub 🤖 on 2026-03-02Z#39242lingohub[bot] wants to merge 1 commit intodevelopfrom
lingohub[bot] wants to merge 1 commit intodevelopfrom
Conversation
Project Name: Rocket.Chat Project Link: https://app.lingohub.com/project/pr_18JCETCbT994-1691/branches/prb_14ONDYI0J1XS-45 User: Lingohub Robot Easy language translations with Lingohub 🚀
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
4 issues found across 57 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/i18n/src/locales/sv.i18n.json">
<violation number="1" location="packages/i18n/src/locales/sv.i18n.json:5384">
P3: The Swedish translation for `User_joined_the_team` was changed to imperative form, which is inconsistent with the past-tense event messages and likely a localization regression.</violation>
</file>
<file name="packages/i18n/src/locales/en.i18n.json">
<violation number="1" location="packages/i18n/src/locales/en.i18n.json:6690">
P2: This key rename breaks the registration error message lookup: the UI still uses `registration.component.form.emailAlreadyInUse`, but English now only defines `emailAlreadyExists`. Keep the old key (or update callers in the same change) to avoid missing translations.</violation>
<violation number="2" location="packages/i18n/src/locales/en.i18n.json:6705">
P2: The registration form still requests `registration.component.form.usernameAlreadyInUse`, but this locale update removes that key. Reintroduce it (or update the caller in the same PR) to prevent missing translation text.</violation>
</file>
<file name="packages/i18n/src/locales/sl-SI.i18n.json">
<violation number="1" location="packages/i18n/src/locales/sl-SI.i18n.json:2590">
P3: The new Slovenian translation for `emailAlreadyExists` has a typo (`E-potšni`), which will display incorrect user-facing text.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| "registration.component.form.requiredField": "This field is required", | ||
| "registration.component.form.sendConfirmationEmail": "Send confirmation email", | ||
| "registration.component.form.submit": "Submit", | ||
| "registration.component.form.userAlreadyExist": "Username already exists. Please try another username.", |
Contributor
There was a problem hiding this comment.
P2: The registration form still requests registration.component.form.usernameAlreadyInUse, but this locale update removes that key. Reintroduce it (or update the caller in the same PR) to prevent missing translation text.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/i18n/src/locales/en.i18n.json, line 6705:
<comment>The registration form still requests `registration.component.form.usernameAlreadyInUse`, but this locale update removes that key. Reintroduce it (or update the caller in the same PR) to prevent missing translation text.</comment>
<file context>
@@ -6706,9 +6702,9 @@
"registration.component.form.requiredField": "This field is required",
"registration.component.form.sendConfirmationEmail": "Send confirmation email",
"registration.component.form.submit": "Submit",
+ "registration.component.form.userAlreadyExist": "Username already exists. Please try another username.",
"registration.component.form.username": "Username",
"registration.component.form.usernameAlreadyExists": "Username already exists. Please try another username.",
</file context>
| "registration.component.form.divider": "or", | ||
| "registration.component.form.email": "Email", | ||
| "registration.component.form.emailAlreadyInUse": "Email already in use", | ||
| "registration.component.form.emailAlreadyExists": "Email already exists", |
Contributor
There was a problem hiding this comment.
P2: This key rename breaks the registration error message lookup: the UI still uses registration.component.form.emailAlreadyInUse, but English now only defines emailAlreadyExists. Keep the old key (or update callers in the same change) to avoid missing translations.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/i18n/src/locales/en.i18n.json, line 6690:
<comment>This key rename breaks the registration error message lookup: the UI still uses `registration.component.form.emailAlreadyInUse`, but English now only defines `emailAlreadyExists`. Keep the old key (or update callers in the same change) to avoid missing translations.</comment>
<file context>
@@ -6690,12 +6687,11 @@
"registration.component.form.divider": "or",
"registration.component.form.email": "Email",
- "registration.component.form.emailAlreadyInUse": "Email already in use",
+ "registration.component.form.emailAlreadyExists": "Email already exists",
"registration.component.form.emailOrUsername": "Email or username",
"registration.component.form.emailPlaceholder": "example@example.com",
</file context>
| "User_joined_the_channel": "anslöt till kanalen", | ||
| "User_joined_the_conversation": "anslöt till konversationen", | ||
| "User_joined_the_team": "anslöt till teamet", | ||
| "User_joined_the_team": "anslut till teamet", |
Contributor
There was a problem hiding this comment.
P3: The Swedish translation for User_joined_the_team was changed to imperative form, which is inconsistent with the past-tense event messages and likely a localization regression.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/i18n/src/locales/sv.i18n.json, line 5384:
<comment>The Swedish translation for `User_joined_the_team` was changed to imperative form, which is inconsistent with the past-tense event messages and likely a localization regression.</comment>
<file context>
@@ -5381,7 +5381,7 @@
"User_joined_the_channel": "anslöt till kanalen",
"User_joined_the_conversation": "anslöt till konversationen",
- "User_joined_the_team": "anslöt till teamet",
+ "User_joined_the_team": "anslut till teamet",
"User_left": "Har lämnat kanalen.",
"User_left_team": "<strong>lämnade</strong> teamet",
</file context>
Suggested change
| "User_joined_the_team": "anslut till teamet", | |
| "User_joined_the_team": "anslöt till teamet", |
| "registration.component.form.confirmPassword": "Potrdi geslo", | ||
| "registration.component.form.divider": "ali", | ||
| "registration.component.form.email": "E-poštni naslov", | ||
| "registration.component.form.emailAlreadyExists": "E-potšni naslov že obstaja", |
Contributor
There was a problem hiding this comment.
P3: The new Slovenian translation for emailAlreadyExists has a typo (E-potšni), which will display incorrect user-facing text.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/i18n/src/locales/sl-SI.i18n.json, line 2590:
<comment>The new Slovenian translation for `emailAlreadyExists` has a typo (`E-potšni`), which will display incorrect user-facing text.</comment>
<file context>
@@ -2587,6 +2587,7 @@
"registration.component.form.confirmPassword": "Potrdi geslo",
"registration.component.form.divider": "ali",
"registration.component.form.email": "E-poštni naslov",
+ "registration.component.form.emailAlreadyExists": "E-potšni naslov že obstaja",
"registration.component.form.invalidConfirmPass": "Potrditev gesla se ne ujema z geslom",
"registration.component.form.invalidEmail": "Vneseni e-poštni naslov je neveljaven",
</file context>
Suggested change
| "registration.component.form.emailAlreadyExists": "E-potšni naslov že obstaja", | |
| "registration.component.form.emailAlreadyExists": "E-poštni naslov že obstaja", |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #39242 +/- ##
===========================================
- Coverage 70.76% 70.74% -0.03%
===========================================
Files 3195 3195
Lines 113106 113106
Branches 20522 20509 -13
===========================================
- Hits 80041 80012 -29
- Misses 31018 31049 +31
+ Partials 2047 2045 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project Name: Rocket.Chat
Project Link: https://app.lingohub.com/project/pr_18JCETCbT994-1691/branches/prb_14ONDYI0J1XS-45
User: Lingohub Robot