chore(cron): Align cron job identifier in userDataDownloads

[Jeet-Patil]

Proposed changes (including videos or screenshots)

Aligned the identifier used in cronJobs.add() and cronJobs.remove() in apps/meteor/server/cron/userDataDownloads.ts.

Previously:

• Job was added using "UserDataDownload"
• Job was removed using "Generate download files for user data"

This mismatch prevented proper removal of the scheduled job when the Disable Data Exporter Processor setting was enabled.
The fix ensures both operations use the same identifier.

Issue(s)

When the Disable Data Exporter Processor setting is enabled:

• The UI updates correctly (export option is removed).
• However, the cron job remains scheduled in MongoDB.
• The job continues executing every 2 minutes despite being disabled.
  This happens because cronJobs.remove() is called with a different identifier than the one used during cronJobs.add().

Steps to test or reproduce

1. Ensure the Disable Data Exporter Processor setting is disabled (processor active).
2. Verify that the job appears in the MongoDB collection.
3. Enable the setting.
4. Observe that:
   • The UI updates correctly.
   • The cron job remains scheduled and continues running.
     After applying this fix:
5. Enable the setting again.
6. Confirm that the scheduled job is properly removed from MongoDB.

Further comments

• Verified locally that aligning the identifier resolves the issue.
• This change does not modify job schema or scheduling behavior.
• It does not introduce backward compatibility issues, as the job is already created using "UserDataDownload".

Summary by CodeRabbit

• Refactor
  • Improved internal handling of background job scheduling and removal to ensure more reliable cron job lifecycle management.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 02e1b50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

Walkthrough

The change modifies the cron job scheduling and removal logic in userDataDownloads.ts to use jobName variable instead of name for registering and unregistering the scheduled job, affecting two lines of code.

Changes

Cohort / File(s)	Summary
Cron Job Variable Reference apps/meteor/server/cron/userDataDownloads.ts	Updated variable references from name to jobName in cron job scheduling and removal operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

type: bug

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately reflects the main change: aligning the cron job identifier in userDataDownloads from inconsistent 'name' and 'jobName' usage.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 1 file

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.86%. Comparing base (2c23512) to head (02e1b50).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #39261   +/-   ##
========================================
  Coverage    70.85%   70.86%           
========================================
  Files         3208     3208           
  Lines       113426   113425    -1     
  Branches     20530    20506   -24     
========================================
+ Hits         80368    80378   +10     
+ Misses       31013    31003   -10     
+ Partials      2045     2044    -1     

Flag	Coverage Δ
e2e	60.33% <ø> (-0.03%)	⬇️
e2e-api	47.80% <100.00%> (-0.03%)	⬇️
unit	71.58% <ø> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.