Skip to content

[Aikido AI] Fix for Potential SQL injection via string-based query concatenation #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Aikido AI] Fix for Potential SQL injection via string-based query concatenation #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions SQL Injection/mysql.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ connection.connect();
router.get('/example1/user/:id', (req,res) => {
let userId = req.params.id;
let query = {
sql : "SELECT * FROM users WHERE id=" + userId
sql : "SELECT * FROM users WHERE id=?",
values: [userId]
}
connection.query(query,(err, result) => {
res.json(result);
Expand All @@ -25,15 +26,16 @@ router.get('/example1/user/:id', (req,res) => {

router.get('/example2/user/:id', (req,res) => {
let userId = req.params.id;
connection.query("SELECT * FROM users WHERE id=" + userId,(err, result) => {
connection.query("SELECT * FROM users WHERE id=?", [userId],(err, result) => {
res.json(result);
});
})

router.get('/example3/user/:id', (req,res) => {
let userId = req.params.id;
connection.query({
sql : "SELECT * FROM users WHERE id=" +userId
sql : "SELECT * FROM users WHERE id=?",
values: [userId]
},(err, result) => {
res.json(result);
});
Expand Down