Skip to content

[Aikido] AI Fix for Possible command injection via Process.Start #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Aikido] AI Fix for Possible command injection via Process.Start #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion Command Injection/OSI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,20 @@ public class OsInjection : ControllerBase
[HttpGet("{binFile}")]
public string os(string binFile)
{
// Restrict to safe binaries in specific directory
string safeDir = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "bin");
string safeName = Path.GetFileName(binFile); // Strip any path components
string fullPath = Path.Combine(safeDir, safeName);

// Whitelist of allowed executables
string[] allowedBinaries = new[] { "safe1.exe", "safe2.exe" };
if (!allowedBinaries.Contains(safeName))
{
throw new UnauthorizedAccessException("Binary not in whitelist");
}

Process p = new Process();
p.StartInfo.FileName = binFile; // Noncompliant
p.StartInfo.FileName = fullPath;
p.StartInfo.RedirectStandardOutput = true;
p.Start();
string output = p.StandardOutput.ReadToEnd();
Expand Down