Code review 1#1

Open

Ruefa wants to merge 29 commits intomasterfrom

code-review-1

Commits on Jun 25, 2019

made quotation marks consistent for strings.
Ruefa
committed
fixed styling to be consistent with flake8 and osu style guides.
Ruefa
committed
created readme
Ruefa
committed
added requirements.txt
Ruefa
committed
added Usage steps to the readme
Ruefa
committed
fixed typo on usage step 1. L -> :
Ruefa
committed
changed from sting concatenation to use f string
Ruefa
committed
created example configuration file
Ruefa
committed
removed api urls from main script. They exist in configuration-example.json now.
Ruefa
committed
changed double quotes to single quotes
Ruefa
committed
added persons api url to configuration
Ruefa
committed
changed to read oauth2 and api urls from configuration file.
Ruefa
committed
changed locations to directory.
Ruefa
committed
had trouble getting directory working. switched back to persons
Ruefa
committed
wrote configuration section on readme
Ruefa
committed
added error handling
Ruefa
committed
fixed typo in readme
Ruefa
committed
updated to python3 in readme
Ruefa
committed
Made directory request work now that the app has access
Ruefa
committed
added comments to get_directory method
Ruefa
committed
fixed json import placement since it is part of python system files
Ruefa
committed
started checking for not 200 error codes instead of a particular error message
Ruefa
committed
used f strings instead of concatination
Ruefa
committed
renamed all variables from camel case to snake case
Ruefa
committed
changed method comment blocks into docstrings
Ruefa
committed
fixed formatting of input loops
Ruefa
committed
made final string for configuration json objects 'api' and 'oauth2'
Ruefa
committed
added method to check if a request has returned with an error
Ruefa
committed
added request error handling to methods
Ruefa
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code review 1#1

Code review 1#1
Ruefa wants to merge 29 commits intomasterfrom
code-review-1

Commits on Jun 25, 2019

made quotation marks consistent for strings.

fixed styling to be consistent with flake8 and osu style guides.

created readme

added requirements.txt

added Usage steps to the readme

fixed typo on usage step 1. L -> :

changed from sting concatenation to use f string

created example configuration file

removed api urls from main script. They exist in configuration-example.json now.

changed double quotes to single quotes

added persons api url to configuration

changed to read oauth2 and api urls from configuration file.

changed locations to directory.

had trouble getting directory working. switched back to persons

wrote configuration section on readme

added error handling

fixed typo in readme

updated to python3 in readme

Made directory request work now that the app has access

added comments to get_directory method

fixed json import placement since it is part of python system files

started checking for not 200 error codes instead of a particular error message

used f strings instead of concatination

renamed all variables from camel case to snake case

changed method comment blocks into docstrings

fixed formatting of input loops

made final string for configuration json objects 'api' and 'oauth2'

added method to check if a request has returned with an error

added request error handling to methods