Open
Conversation
ew3361zh
approved these changes
Mar 4, 2026
JoeWaddell
reviewed
Mar 4, 2026
Collaborator
JoeWaddell
left a comment
JoeWaddell
left a comment
There was a problem hiding this comment.
Some additional updates for PR number mismatches
changelog.md
Outdated
| - [2655](https://github.com/RuminantFarmSystems/RuFaS/pull/2655) - [minor change] [Animal] [InputChange] [NoOutputChange] Updated RationManager class to allow for more flexibility in user inputs in Feed input file. | ||
| - [2670](https://github.com/RuminantFarmSystems/RuFaS/pull/2670) - [minor change] [Animal] [InputChange] [NoOutputChange] Updated Animal module unit testing to 100% coverage. | ||
| - [2673](https://github.com/RuminantFarmSystems/RuFaS/pull/2673) - [minor change] [Feed] [InputChange] [NoOutputChange] Adds a default for purchased feed buffer of 0.15. | ||
|
|
Collaborator
There was a problem hiding this comment.
are the empty lines intentional?
changelog.md
Outdated
| - [2732](https://github.com/RuminantFarmSystems/RuFaS/pull/2732) - [minor change] [NoInputChange] [NoOutputChange] Skip Animal module and Manure module if no animals are present in simulation. | ||
| - [2739](https://github.com/RuminantFarmSystems/RuFaS/pull/2739) - [minor change] [NoInputChange] [NoOutputChange] Fixes manure outputs and updates E2E expected results accordingly. | ||
| - [2763](https://github.com/RuminantFarmSystems/RuFaS/pull/2763) - [minor change] [NoInputChange] [NoOutputChange] Fixes feed order issue by sorting user feed inputs. | ||
|
|
Collaborator
There was a problem hiding this comment.
same question re: empty lines
| - [2138](https://github.com/RuminantFarmSystems/RuFaS/pull/2138) - [minor change] [Animal] Refreshes module which calculates the nutrients supplied to an animal by a ration. | ||
| - [2128](https://github.com/RuminantFarmSystems/RuFaS/pull/2128) - [minor change] [Animal] Updates culling-related metadata descriptions | ||
| - [2162](https://github.com/RuminantFarmSystems/RuFaS/pull/2162) - [minor change] [Data Collection App] Replace the usage of PROPERTIES_TO_CREATE_SCHEMA_FOR with property's boolean field "data_collection_app_compatible". | ||
| - [2164](https://github.com/RuminantFarmSystems/RuFaS/pull/2128) - [minor change] [GraphGenerator] Aligns graphs with alphabetized, user-customized GG legend. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - [2164](https://github.com/RuminantFarmSystems/RuFaS/pull/2128) - [minor change] [GraphGenerator] Aligns graphs with alphabetized, user-customized GG legend. | |
| - [2164](https://github.com/RuminantFarmSystems/RuFaS/pull/2164) - [minor change] [GraphGenerator] Aligns graphs with alphabetized, user-customized GG legend. |
| - [2332](https://github.com/RuminantFarmSystems/RuFaS/pull/2332) - [minor change] [Crop & Soil] Refactor `Field._execute_manure_application()` and increase test coverage of field.py to 100%. | ||
| - [2327](https://github.com/RuminantFarmSystems/RuFaS/pull/2327) - [minor change] [Animal] Reduces the number of warnings during a default simulation run. | ||
| - [2318](https://github.com/RuminantFarmSystems/RuFaS/pull/2318) - [minor change] [Manure] Step 1/3 for implementing the refreshed ManureManager: initialization process including input validation, creating processor instances, and populating the adjacency matrix. | ||
| - [2328](https://github.com/RuminantFarmSystems/RuFaS/pull/2318) - [minor change] [Manure] Re-implements the logic for compost bedded pack barn.. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - [2328](https://github.com/RuminantFarmSystems/RuFaS/pull/2318) - [minor change] [Manure] Re-implements the logic for compost bedded pack barn.. | |
| - [2328](https://github.com/RuminantFarmSystems/RuFaS/pull/2328) - [minor change] [Manure] Re-implements the logic for compost bedded pack barn.. |
Co-authored-by: JoeWaddell <109082924+JoeWaddell@users.noreply.github.com>
Co-authored-by: JoeWaddell <109082924+JoeWaddell@users.noreply.github.com>
Co-authored-by: JoeWaddell <109082924+JoeWaddell@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
There were a couple of errors in the changelong PR#s and links
What
Updated links for PR 2678, 2673 and removed 2676 which doesn't exist