[Reports][Emissions] Update emissions.py filtering process#2854
Merged
allisterakun merged 21 commits intodevfrom Mar 20, 2026
Merged
[Reports][Emissions] Update emissions.py filtering process#2854allisterakun merged 21 commits intodevfrom
allisterakun merged 21 commits intodevfrom
Conversation
Contributor
|
Current Coverage: 99% Mypy errors on remove_use_filter_key branch: 1252 |
Contributor
|
Current Coverage: 99% Mypy errors on remove_use_filter_key branch: 1250 |
Contributor
|
Current Coverage: 99% Mypy errors on remove_use_filter_key branch: 1250 |
matthew7838
approved these changes
Mar 12, 2026
Collaborator
matthew7838
left a comment
matthew7838
left a comment
There was a problem hiding this comment.
LGTM, outputs look the same. A few minor things:
- Remove the "use_filter_key_name" key in OM
validate_report_filters. - The changes are not that intuitive, add a bit more details in the PR description for the sake of future bookkeeping and reference.
- Be sure to clear the new mypy errors before merging.
Contributor
|
Current Coverage: 99% Mypy errors on remove_use_filter_key branch: 1214 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Issue(s) closed by this pull request: closes #2718
This PR removes the
use_filter_key_nameoption in the OM filter.Also updates the filter processing functions in
emissions.pywhich was still using the deprecateduse_filter_key_nameoption.There are no affect on the Input or Output of the simulation, only the behind-the-scene process was updated.
Input Changes
Output Changes
Filter