Skip to content

Updates to SciDoc Formatting (03/04) Additional Changes Tables pg 55-57 (03/15)#2865

Merged
gmg228 merged 10 commits intodevfrom
testscidocformatupdate_030426
Mar 18, 2026
Merged

Updates to SciDoc Formatting (03/04) Additional Changes Tables pg 55-57 (03/15)#2865
gmg228 merged 10 commits intodevfrom
testscidocformatupdate_030426

Conversation

@gmg228
Copy link
Contributor

@gmg228 gmg228 commented Mar 15, 2026

Formatting changes to sci doc.
Adjusted tables pages 55 to 57 and updated EQ notes.

Scientific Documentation.pdf

Issue(s) closed by this pull request: closes #

What

Why

How

Test plan

Input Changes

Output Changes

  • N/A

Filter

@github-actions
Copy link
Contributor

Current Coverage: 99%

Mypy errors on testscidocformatupdate_030426 branch: 1249
Mypy errors on dev branch: 1249
No difference in error counts

@github-actions
Copy link
Contributor

🚨 Please update the changelog. This PR cannot be merged until changelog.md is updated.

@LisaM-kiwi LisaM-kiwi self-requested a review March 16, 2026 15:09
@github-actions
Copy link
Contributor

Current Coverage: 99%

Mypy errors on testscidocformatupdate_030426 branch: 1249
Mypy errors on dev branch: 1249
No difference in error counts

@github-actions
Copy link
Contributor

🚨 Please update the changelog. This PR cannot be merged until changelog.md is updated.

Copy link
Contributor

@LisaM-kiwi LisaM-kiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tables look good!

@elle-andreen
Copy link
Contributor

These changes look great to me! The doc is a lot more consistently formatted throughout now. I noted the following after doing a quick look through the PDF:

  • Some tables, e.g. those on page 81-83, appear on their own page - I'm not sure if this is intentional. It's okay with me either way!
  • Pg 98 is landscape but with nothing on it
  • Table of constants only exists in the manure module, but that's not necessarily a problem that should be solved in this PR

Depending on where we're at with the potential conversion to Quarto, I'd be fine with these changes merging as-is, or fixing the items (except bullet 3) above. Thanks Geneva! 😃

@github-actions
Copy link
Contributor

Current Coverage: 99%

Mypy errors on testscidocformatupdate_030426 branch: 1213
Mypy errors on dev branch: 1213
No difference in error counts

@github-actions
Copy link
Contributor

🚨 Please update the changelog. This PR cannot be merged until changelog.md is updated.

@gmg228
Copy link
Contributor Author

gmg228 commented Mar 18, 2026

Thank you @LisaM-kiwi and @elle-andreen !

The tables look good!

Great! I'm glad pg 55-57 look better and Eq IDs are now appearing appropriately.

  • Some tables, e.g. those on page 81-83, appear on their own page - I'm not sure if this is intentional. It's okay with me either way!
  • Pg 98 is landscape but with nothing on it
  • Table of constants only exists in the manure module, but that's not necessarily a problem that should be solved in this PR

Great callout. Those tables (81-83) are intentionally on their own page!
Page 98 appeared to be created to accommodate a footnote for a table on page 97. This has been fixed!
You are absolutely correct. This should be amended in the next SciDoc version udpate.

New Doc for review!
scidoc_31826.pdf

@github-actions
Copy link
Contributor

Current Coverage: 99%

Mypy errors on testscidocformatupdate_030426 branch: 1213
Mypy errors on dev branch: 1213
No difference in error counts

@github-actions
Copy link
Contributor

🚨 Please update the changelog. This PR cannot be merged until changelog.md is updated.

@github-actions
Copy link
Contributor

Current Coverage: 99%

Mypy errors on testscidocformatupdate_030426 branch: 1213
Mypy errors on dev branch: 1213
No difference in error counts

Copy link
Contributor

@elle-andreen elle-andreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good to me! Thanks Geneva!

@gmg228 gmg228 merged commit 99b9a3a into dev Mar 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants