Remove properties and cross_validation FilePaths from metadata#2869
Remove properties and cross_validation FilePaths from metadata#2869allisterakun wants to merge 9 commits intodevfrom
properties and cross_validation FilePaths from metadata#2869Conversation
|
Current Coverage: % Mypy errors on remove_properties_fp_from_metadata branch: 1213 |
|
🚨 Please update the changelog. This PR cannot be merged until |
|
Current Coverage: 99% Mypy errors on remove_properties_fp_from_metadata branch: 1213 |
|
🚨 Please update the changelog. This PR cannot be merged until |
ew3361zh
left a comment
ew3361zh
left a comment
There was a problem hiding this comment.
LGTM, nice work Allister.
| }, | ||
| "cross_validation_file_paths": { | ||
| "type": "array", | ||
| "description": "Collection of file paths to the cross validation rule JSON files.", |
There was a problem hiding this comment.
| "description": "Collection of file paths to the cross validation rule JSON files.", | |
| "description": "List the of file path(s) to the cross validation rule JSON file(s).", |
| "feed_storage_configurations", | ||
| "feed_storage_instances", | ||
| } | ||
| PRROPERTIES_FILE_PATHS: dict[str, Path] = { |
There was a problem hiding this comment.
Do you think docstrings would be helpful here? I know we're not doing it anywhere else in this file but we do it in manure files for file-level constants. Just a thought.
3 participants
Context
Issue(s) closed by this pull request: closes #2859.
What
Why
How
Test plan
Input Changes
Output Changes
Filter