Skip to content

[Fix / add egg-id to response] - 빠진 egg-id 응답에 추가 #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekgns33 merged 2 commits into from
Jul 9, 2025
Merged

[Fix / add egg-id to response] - 빠진 egg-id 응답에 추가 #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdb9ea4
:bug: fix : add egg-id to response
ekgns33 Jul 9, 2025
88bbe15
:bug: test : fix test-code
ekgns33 Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/org/runimo/runimo/auth/service/dto/SignupUserResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ public record SignupUserResponse(
String greetingEggName,
String greetingEggType,
String greetingEggImgUrl,
String eggCode
String eggCode,
Long eggId
) {

public SignupUserResponse(final User user, final TokenPair tokenPair, final Egg greetingEgg,
Expand All @@ -23,7 +24,8 @@ public SignupUserResponse(final User user, final TokenPair tokenPair, final Egg
greetingEgg.getName(),
greetingEgg.getEggType().getName(),
greetingEgg.getImgUrl(),
eggCode
eggCode,
greetingEgg.getId()
Comment on lines +27 to +28
Copy link

@coderabbitai coderabbitai bot Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

❓ Verification inconclusive

Verify the API response structure is documented.

The constructor correctly passes the egg ID from the domain object. Ensure that the new egg_id field is properly documented in your API documentation for client consumers.

🏁 Script executed:

#!/bin/bash
# Check if there are any API documentation files that need to be updated
fd -e yaml -e json -e md | xargs grep -l -i "signup.*response\|eggcode" | head -10

Length of output: 84

Let’s broaden the search to catch both egg_id and eggId, and also look for any direct mentions of SignupUserResponse in your docs:

🏁 Script executed:

#!/bin/bash
# Search for 'egg_id' or 'eggId' in documentation files
fd -e yaml -e yml -e json -e md | xargs grep -i -l "egg[_]?id"

# Search for any references to the DTO name in documentation
fd -e yaml -e yml -e json -e md | xargs grep -i -l "SignupUserResponse"

Length of output: 136

Document the new egg_id field in your API docs

The SignupUserResponse DTO now includes an egg_id property, but it isn’t referenced in any existing API documentation. Please update your docs so client teams know to expect this field.

• In your OpenAPI/Swagger spec (e.g. api.yaml or openapi.yml), add egg_id under the signup response schema.
• Update any Markdown reference guides (e.g. docs/, README.md) that describe the signup endpoint.
• If you have other formats (Asciidoc, JSON examples, etc.), ensure they include the new field.

🤖 Prompt for AI Agents 
In src/main/java/org/runimo/runimo/auth/service/dto/SignupUserResponse.java
around lines 27 to 28, the new egg_id field added to the DTO is not documented
in the API specs. Update the OpenAPI/Swagger specification file (such as
api.yaml or openapi.yml) to include egg_id in the signup response schema. Also,
revise any Markdown documentation files like those in docs/ or README.md that
describe the signup endpoint to mention this field. Additionally, ensure any
other documentation formats or example files reflect the inclusion of egg_id.

);
}
}
3 changes: 2 additions & 1 deletion src/test/java/org/runimo/runimo/auth/controller/AuthAcceptanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ void tearDown() {
.log().all()
.body("payload.nickname", equalTo("username"))
.body("payload.token_pair.access_token", notNullValue())
.body("payload.token_pair.refresh_token", notNullValue());
.body("payload.token_pair.refresh_token", notNullValue())
.body("payload.egg_id", notNullValue());
}

@Test
Expand Down
6 changes: 4 additions & 2 deletions src/test/java/org/runimo/runimo/auth/controller/AuthControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ class AuthControllerTest {
"exmaple_egg_name",
"example_egg_type",
"example_egg_url",
"ECODE"
"ECODE",
1L
)
);

Expand Down Expand Up @@ -196,7 +197,8 @@ class AuthControllerTest {
"exmaple_egg_name",
"example_egg_type",
"example_egg_url",
"ECODE"
"ECODE",
1L
)
);

Expand Down
3 changes: 2 additions & 1 deletion src/test/java/org/runimo/runimo/user/api/UserItemAcceptanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ void tearDown() {
"마당알",
"MADANG",
"test.url",
"ECODE"
"ECODE",
1L
));

AuthSignupRequest request = new AuthSignupRequest(
Expand Down