Fix collapsed group spacing for empty groups#495
Open
jeffscottward wants to merge 3 commits intoRunMaestro:mainfrom
Open
Fix collapsed group spacing for empty groups#495jeffscottward wants to merge 3 commits intoRunMaestro:mainfrom
jeffscottward wants to merge 3 commits intoRunMaestro:mainfrom
Conversation
📝 WalkthroughWalkthroughPrecomputes non-parent session items per group in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis PR fixes a UI spacing bug where collapsing a group that contains no top-level agents (i.e., Changes made:
The fix is minimal, targeted, and logically correct. No side effects are introduced for the expanded-group path or for groups that do have top-level sessions. Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Render Group] --> B{group.collapsed?}
B -- No --> C[Render expanded session list\nwith border-l]
B -- Yes --> D{groupCollapsedPills\n.length > 0?}
D -- Yes --> E[Render collapsed pill container\nml-8 mr-3 mt-1 mb-2]
D -- No --> F[Render null\nno spacing / no container]
Last reviewed commit: 5002a82 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Collaborator
|
This looks safe, but on the fact chance that it causes some regression or is going to hold off on 0.15.0 ... first merge after i publish that version. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@prompt.XXXXXX.txt`:
- Around line 1-17: Delete the generated artifact file "prompt.XXXXXX.txt" from
the branch (remove it from the PR changes) so it is no longer tracked or part of
the commit set; locate the file by name in the diff/commit and remove it (git rm
/ delete and commit/push) and ensure it is not reintroduced (optionally add the
filename pattern to .gitignore) so lint/format and tests no longer fail due to
this non-product file.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
payload.XXXXXX.jsonprompt.XXXXXX.txt
✅ Files skipped from review due to trivial changes (1)
- payload.XXXXXX.json
Comment on lines
+1
to
+17
| You are an autonomous coding agent fixing a GitHub pull request for Maestro. | ||
|
|
||
| Goal: | ||
| - Fix only what is necessary to make the failing checks pass for PR #495. | ||
| - Use the failure payload below to focus changes. | ||
| - Keep changes minimal and scoped. | ||
| - Do not add broad refactors or formatting churn. | ||
| - If no safe fix exists, do not force risky behavior and return without edits. | ||
|
|
||
| Context: | ||
| - PR repo: RunMaestro/Maestro | ||
| - PR number: 495 | ||
| - Head branch: group-css-fix | ||
| - Head SHA: 5002a82e9a19591e7de9323fb2876e6b90989660 | ||
|
|
||
| Failing check payload: | ||
| {"repo":"RunMaestro/Maestro","number":495,"title":"Fix collapsed group spacing for empty groups","htmlUrl":"https://github.com/RunMaestro/Maestro/pull/495","head":"5002a82e9a19591e7de9323fb2876e6b90989660","failures":[{"source":"check-run","id":65325337465,"name":"test","status":"completed","conclusion":"failure","htmlUrl":"https://github.com/RunMaestro/Maestro/actions/runs/22552813651/job/65325337465","detailsUrl":"https://github.com/RunMaestro/Maestro/actions/runs/22552813651/job/65325337465","summary":"","notes":".github:48776:failure Process completed with exit code 1. | src/__tests__/renderer/components/TerminalOutput.test.tsx:243:failure Error: expect(received).toBeInTheDocument()\n\nreceived value must be an HTMLElement or an SVGElement.\nReceived has type: Null\nReceived has value: null\n ❯ src/__tests__/renderer/components/TerminalOutput.test.tsx:243:33\n\n","completedAt":"2026-03-01T21:23:04Z"},{"source":"check-run","id":65325337460,"name":"lint-and-format","status":"completed","conclusion":"failure","htmlUrl":"https://github.com/RunMaestro/Maestro/actions/runs/22552813651/job/65325337460","detailsUrl":"https://github.com/RunMaestro/Maestro/actions/runs/22552813651/job/65325337460","summary":"","notes":".github:10:failure Process completed with exit code 1.","completedAt":"2026-03-01T21:16:29Z"}]} No newline at end of file |
There was a problem hiding this comment.
Remove generated prompt artifact from the PR scope.
This file is not part of the product fix and looks like agent/tooling output. Keeping it adds review noise and can contribute to lint/format failures (notably the very long JSON on Line 17). Please drop this file from the PR.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~17-~17: The official name of this software platform is spelled with a capital “H”.
Context: ...job/65325337465","summary":"","notes":".github:48776:failure Process completed with ex...
(GITHUB)
[uncategorized] ~17-~17: The official name of this software platform is spelled with a capital “H”.
Context: ...job/65325337460","summary":"","notes":".github:10:failure Process completed with exit ...
(GITHUB)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@prompt.XXXXXX.txt` around lines 1 - 17, Delete the generated artifact file
"prompt.XXXXXX.txt" from the branch (remove it from the PR changes) so it is no
longer tracked or part of the commit set; locate the file by name in the
diff/commit and remove it (git rm / delete and commit/push) and ensure it is not
reintroduced (optionally add the filename pattern to .gitignore) so lint/format
and tests no longer fail due to this non-product file.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/releases.md`:
- Line 35: Fix typos and grammar in the release notes by replacing the incorrect
tokens: change "FIle" to "File" in the sentence that begins "🗄️ Document
Graphs. Launch from file preview...", change "built in" to "built-in", change
"You will received" to "You will receive", and change "Github" to "GitHub" so
the release notes read with correct spelling and hyphenation.
- Line 41: Update the subsection headings in the releases document to use
consistent third-level headings (###) under each release's second-level heading
(## vX.Y.x) and fix the typo in the release title "Smaller Changes in 014.x" to
"Smaller Changes in 0.14.x"; specifically replace any stray top-level (#) or
second-level (##) headings within release sections (e.g., the "Smaller Changes
in 014.x" heading and the other subsections currently using `#/`##) with ### so
the document hierarchy and generated TOC remain correct.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
docs/releases.mdpayload.XXXXXX.jsonsrc/renderer/components/FilePreview.tsxsrc/renderer/hooks/batch/useBatchProcessor.ts
✅ Files skipped from review due to trivial changes (1)
- src/renderer/hooks/batch/useBatchProcessor.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- payload.XXXXXX.json
|
|
||
| The major contributions to 0.14.x remain: | ||
|
|
||
| 🗄️ Document Graphs. Launch from file preview or from the FIle tree panel. Explore relationships between Markdown documents that contain links between documents and to URLs. |
There was a problem hiding this comment.
Fix user-facing release note typos/grammar.
Line 35 (FIle), Line 110 (built in → built-in), Line 114 (You will received), and Line 135 (Github → GitHub) should be corrected for publication quality.
Also applies to: 110-110, 114-114, 135-135
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/releases.md` at line 35, Fix typos and grammar in the release notes by
replacing the incorrect tokens: change "FIle" to "File" in the sentence that
begins "🗄️ Document Graphs. Launch from file preview...", change "built in" to
"built-in", change "You will received" to "You will receive", and change
"Github" to "GitHub" so the release notes read with correct spelling and
hyphenation.
|
|
||
| 🧙♂️ Added an in-tab wizard for generating Auto Run Playbooks via `/wizard` or a new button in the Auto Run panel. | ||
|
|
||
| # Smaller Changes in 014.x |
There was a problem hiding this comment.
Normalize subsection heading levels to preserve document hierarchy.
Line 41, Lines 104-116, Line 137, and Lines 229-259 switch to #/## headings inside release sections. This breaks the heading structure and can degrade generated TOC/navigation. These should be consistent subsection levels (typically ### under each ## vX.Y.x section). Also, Line 41 should read 0.14.x, not 014.x.
Also applies to: 104-116, 137-137, 229-259
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/releases.md` at line 41, Update the subsection headings in the releases
document to use consistent third-level headings (###) under each release's
second-level heading (## vX.Y.x) and fix the typo in the release title "Smaller
Changes in 014.x" to "Smaller Changes in 0.14.x"; specifically replace any stray
top-level (#) or second-level (##) headings within release sections (e.g., the
"Smaller Changes in 014.x" heading and the other subsections currently using
`#/`##) with ### so the document hierarchy and generated TOC remain correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #494
Summary by CodeRabbit