Array init with 0i32 uses 0u32 instead#227
Merged
LegNeato merged 2 commits intoRust-GPU:mainfrom Apr 9, 2025
Merged
Conversation
Fixes Rust-GPU#85. Fixes EmbarkStudios/rust-gpu#1061 Thanks to @LegNeato
|
@LegNeato Works. I haven't done extensive testing but the project I am working on does comppile with this. Previously I was using: let mut seed_array = [1i32; 56];
for i in 0..56 {
seed_array[i] = 0;
}Now I am able to directly do: |
Collaborator
Author
|
Thanks @JulianKnodt for the original fix! |
Member
|
btw in compiletest you can put multiple entry points in a single file if you just want to check that they compile and not disassemble them |
Firestar99
approved these changes
Apr 9, 2025
Collaborator
Author
|
Yeah, those were just the original tests and figure it doesn't hurt really. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated from EmbarkStudios/rust-gpu#1143
closes #85
original issue: EmbarkStudios/rust-gpu#1061