Do not ICE on indirect fn pointers #453
Merged
+77
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
approved these changes
Oct 28, 2025
eddyb
reviewed
Oct 28, 2025
Comment on lines
239
to
+240
| if inst.class.opcode == Op::FunctionCall { | ||
| let callee = func_id_to_idx[&inst.operands[0].unwrap_id_ref()]; | ||
| let callee_had_err = | ||
| visit(sess, module, visited, stack, names, callee, func_id_to_idx).err(); | ||
| any_err = any_err.or(callee_had_err); | ||
| let callee_id = inst.operands[0].unwrap_id_ref(); |
There was a problem hiding this comment.
For the record, this code in simple_passes isn't incorrect.
The underlying bug¹ is that OpFunctionCall is still used with function pointers - the correct instruction is OpFunctionPointerCallINTEL (from the same SPIR-V extension that adds function pointers through a new CodeSectionINTEL Storage Class).
¹(which one of my branches fixes, been meaning to open a PR for that for a while, already landed most of its prerequisites earlier this year)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ICE in #452.