Skip to content

Implement use-rect for leptos #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Implement use-rect for leptos #546

wants to merge 25 commits into from

Conversation

@omar-mohamed-khallaf
Copy link

@omar-mohamed-khallaf omar-mohamed-khallaf commented Jun 16, 2025 •
edited
Loading

Closes #64

omar-mohamed-khallaf and others added 5 commits June 16, 2025 07:38
@omar-mohamed-khallaf
wip: initial leptos port for use-rect
d6d4a1d 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
wip: complete implementation
2084f92 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
Merge branch 'RustForWeb:main' into main
7abb9a8
@omar-mohamed-khallaf
Don't call callbacks with the lock held
4b3a8db 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
Optimize searching for observed element
641e780 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf omar-mohamed-khallaf marked this pull request as ready for review June 16, 2025 10:33
omar-mohamed-khallaf and others added 20 commits June 16, 2025 13:36
@omar-mohamed-khallaf
Merge branch 'RustForWeb:main' into main
d7e5fdf
@omar-mohamed-khallaf
replace Arc with Rc
c2bedcd 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
use borderbox for ResizeObserver option
39fe6a2 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
rename variable
539fb3d 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
Hashmap implementation for use-rect
f4b4bd6 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
refactor: new implementation using js_sys
01ff2d1 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
fix: dependencies
3a56d34 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
fix: use_rect
336b59b 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
fix: use_rect
a6e22b1 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
Revert "fix: use_rect"
c5b0260 
This reverts commit a6e22b1.
@omar-mohamed-khallaf
fix: call callbacks when the element is found
da54910 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
feat: generalize observe_element and use it for use_size
c57d8ee 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
use dyn_ref when possible
2bc4835 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
fix typo
4fa5c81 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
fix: logical error
a354d34 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
chores
511d127 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
fix: remove duplicate search for element in map
769b865 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
refactor
a566886 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
fix: remove duplicate set of size on initial observation
4440706 
Signed-off-by: Omar Mohamed <mohamed.omar67492@gmail.com>
@omar-mohamed-khallaf
Merge branch 'main' into main
3892a47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add use rect for Leptos

1 participant

@omar-mohamed-khallaf