Entered the measurements of the SAM masks of ERIS into get_infos_obs.py.#179
Entered the measurements of the SAM masks of ERIS into get_infos_obs.py.#179JHayoz wants to merge 5 commits intoSAIL-Labs:mainfrom
Conversation
Please note that the two cameras within ERIS are misaligned w.r.t each other, which is why there are two measurements for each SAM mask: one for each of the camera (JHK or LM).
for more information, see https://pre-commit.ci
Added a function to compute the position angle for ERIS based on simple linear interpolation between the start and end parallactic angles, and taking into account the pupil angle.
for more information, see https://pre-commit.ci
|
Hi @JHayoz, Thanks for implementing the ERIS compatibility into AMICAL. Everything looks good! Did you test your branch on an actual dataset? Also, we recommend including some appropriate tests (using pytest) for any new features (or instruments in your case). See contributing.md. If you have some public dataset you want to test on, we can work to generate an example script (as for VLT/SPHERE). Let me know what you want to do. |
|
It seems that this PR doesn't really add new functionalities, just data for a new instrument, so additional tests are perhaps not needed? Would be nice to have it included in AMICAL to attract VLT/ERIS users 😊 |
|
Ah it seems that I forgot to reply, sorry! Yes, indeed, this PR adds two things: the dimensions of the pupil masks for VLT/ERIS, and a method to compute the position angle from VLT/ERIS data based on the ERIS user manual. I did apply my branch on ERIS commissioning datasets, however these are not public (at least not yet). Since I have stopped working on this project, I hope that someone else can provide a test, if necessary. |
3 participants
Please note that the two cameras within ERIS are misaligned w.r.t each other, which is why there are two measurements for each SAM mask: one for each of the camera (JHK or LM).