Skip to content

feat: support partial translation via apply_to array #768

Open
n-o-u-r-h-a-n wants to merge 42 commits intomainfrom
support-partial-translation
Open

feat: support partial translation via apply_to array #768
n-o-u-r-h-a-n wants to merge 42 commits intomainfrom
support-partial-translation

Conversation

@n-o-u-r-h-a-n
Copy link
Contributor

@n-o-u-r-h-a-n n-o-u-r-h-a-n commented Feb 25, 2026 •
edited
Loading

Context

AI/ai-sdk-java-backlog#341.

Apply_to array is now supported instead of being set to null to support partial translation of the user's prompt.

Feature scope:

  • TranslationApplyToSelector a new class was created as a convenience builder for SAPDocumentTranslationApplyToSelector.
  • Sample code was updated.
  • Translation test was updated in OrchestrationTest.
    • New tests were added in OrchestrationModuleConfigTest to cover the new class methods.

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

CharlesDuboisSAP
CharlesDuboisSAP reviewed Feb 25, 2026
View reviewed changes
Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the API that you write is fluent.

Not readable doesn't flow:

.withApplyTo(
  List.of(
    TranslationApplyToSelector.placeholders(List.of("exam_type", "topic")),
    TranslationApplyToSelector.templateRoles(TemplateRole.ASSISTANT)))

Readable and flows:

.applyToPlaceholders("exam_type", "topic")
.applyToTemplateRoles(TemplateRole.ASSISTANT)

n-o-u-r-h-a-n and others added 26 commits February 25, 2026 11:58
@n-o-u-r-h-a-n @CharlesDuboisSAP
Update sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/servic…
a429f37 
…es/OrchestrationService.java

Co-authored-by: Charles Dubois <103174266+CharlesDuboisSAP@users.noreply.github.com>
@bot-sdk-js
Formatting
46230db
@n-o-u-r-h-a-n
reverting
fdf7a5e
@bot-sdk-js
Formatting
5b8e536
@n-o-u-r-h-a-n
refactoring the new class name
9a5a200
@n-o-u-r-h-a-n
Merge remote-tracking branch 'origin/support-partial-translation' int…
8d61683 
…o support-partial-translation
@bot-sdk-js
Formatting
d3cf79d
@n-o-u-r-h-a-n
reverting a comment
dc21aea
@n-o-u-r-h-a-n
Merge remote-tracking branch 'origin/support-partial-translation' int…
212e506 
…o support-partial-translation
@n-o-u-r-h-a-n
Merge branch 'main' into support-partial-translation
0ecab09
@n-o-u-r-h-a-n
fixed test + reduced methods
0fb1bc3
@n-o-u-r-h-a-n
Merge remote-tracking branch 'origin/support-partial-translation' int…
08e8d82 
…o support-partial-translation
@bot-sdk-js
Formatting
20b4c27
@n-o-u-r-h-a-n
further method reduction
7918494
@n-o-u-r-h-a-n
Merge remote-tracking branch 'origin/support-partial-translation' int…
f2ed08d 
…o support-partial-translation
@bot-sdk-js
Formatting
2d3ef5b
@n-o-u-r-h-a-n
updating constructors
e6ebe2f
@n-o-u-r-h-a-n
Merge remote-tracking branch 'origin/support-partial-translation' int…
bb9f590 
…o support-partial-translation
@n-o-u-r-h-a-n
Merge branch 'refs/heads/main' into support-partial-translation
df9db78
@n-o-u-r-h-a-n
fix tests + mistake from old pr
aec7e6e
@bot-sdk-js
Formatting
593d4c4
@n-o-u-r-h-a-n
formatting
4b13d42
@n-o-u-r-h-a-n
fix source language
3ce80b1
@n-o-u-r-h-a-n
fix tests
b7f03e6
@n-o-u-r-h-a-n
Merge remote-tracking branch 'origin/support-partial-translation' int…
caf4fb0 
…o support-partial-translation

# Conflicts:
#	orchestration/src/main/java/com/sap/ai/sdk/orchestration/TranslationConfig.java
#	orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationModuleConfigTest.java
@bot-sdk-js
Formatting
7186853
CharlesDuboisSAP
CharlesDuboisSAP reviewed Mar 2, 2026
View reviewed changes
Jonas-Isr
Jonas-Isr reviewed Mar 3, 2026
View reviewed changes
Copy link
Member

@Jonas-Isr Jonas-Isr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall. Mostly smaller stuff I noticed 🙂

Jonas-Isr
Jonas-Isr reviewed Mar 4, 2026
View reviewed changes
Copy link
Member

@Jonas-Isr Jonas-Isr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good :)

orchestration/src/main/java/com/sap/ai/sdk/orchestration/TranslationConfig.java
String targetLanguage;

@With String sourceLanguage;
@Getter String sourceLanguage;
Copy link
Member

@Jonas-Isr Jonas-Isr Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Getter String sourceLanguage;
String sourceLanguage;

You don't need the @Getter here, @Value already adds getters to the fields.

orchestration/src/main/java/com/sap/ai/sdk/orchestration/TranslationConfig.java
Comment on lines +130 to +136
/**
* Set the source language for this translation. If no selectors are used, this applies to the
* whole message. If selectors are used, this applies to the most recently added selector.
*
* @param sourceLanguage The source language code
* @return A new Input with the given source language applied.
*/
Copy link
Member

@Jonas-Isr Jonas-Isr Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to highlight the behaviour a bit more.

Suggested change
/**
* Set the source language for this translation. If no selectors are used, this applies to the
* whole message. If selectors are used, this applies to the most recently added selector.
*
* @param sourceLanguage The source language code
* @return A new Input with the given source language applied.
*/
/**
* Set the source language for this translation.
* <br>
* <strong>Important Note:</strong> If no selectors are used, this applies to the
* whole message. If selectors are used, this applies to the most recently added selector.
*
* @param sourceLanguage The source language code
* @return A new Input with the given source language applied.
*/

orchestration/src/main/java/com/sap/ai/sdk/orchestration/TranslationConfig.java
String targetLanguage;

@With String sourceLanguage;
@Getter @With String sourceLanguage;
Copy link
Member

@Jonas-Isr Jonas-Isr Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getter is added by @Value already.

Suggested change
@Getter @With String sourceLanguage;
@With String sourceLanguage;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CharlesDuboisSAP CharlesDuboisSAP CharlesDuboisSAP left review comments

@Jonas-Isr Jonas-Isr Jonas-Isr left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@n-o-u-r-h-a-n @CharlesDuboisSAP @Jonas-Isr @bot-sdk-js