Open
Conversation
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
droshev
changed the title
droshev
changed the title
MariaIDineva
reviewed
Apr 3, 2026
Contributor
MariaIDineva
left a comment
MariaIDineva
left a comment
There was a problem hiding this comment.
I, personally, like the idea of having the table of contents. Looks nice!
Here are also some ideas for improvement which I came up with while playing with the changes.
- First, it's nice that you can hover on the title for each section and a # is displayed, so you can get a reference to a particular section by clicking on the #. Ideas for improvement:
-
Maybe the whole title could be made clickable and clicking on it (not only on the #) could bring a change in the url, reflecting the specific section chosen.
-
Upon clicking in the #, the table of contents disappear (check the video). I guess that is not desired.
Screen.Recording.2026-04-03.at.11.14.16.mov
- Second, I feel like clicking on each of the lines in the table of contents should also bring a change to the url, not only scroll up and down the page. Eg: When clicking on "Mobile View" url should change from
#/core/action-sheetto#/core/action-sheet#mobile, just like it happens when you click on the # of the title in the main section.
Screen.Recording.2026-04-03.at.11.26.47.mov
droshev
force-pushed
the
docs/ui-improvements
branch
from
8d9daab to
08b539c
Compare
Contributor
Author
addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
closes
Description
Screenshots