refactor: Update ESLint configurations for ESLint 9 compatibility

.github/workflows/pipeline.yml

@@ -4,7 +4,9 @@ on:
     push:
         branches: [main]
     pull_request:
-        branches: [main]
+        branches: 
+        -  main
+        - 'eslint9**'
 jobs:
     build:
         strategy:

eslint.config.js

@@ -54,6 +54,7 @@ module.exports = [
             '.storybook',
             '**/snapshotResolver.js',
             '**/expected-output/**',
+            '**/playwright-report/**'
         ]
     },
     eslintPluginPrettierRecommended,

package.json

@@ -23,7 +23,6 @@
         "eslint-plugin-prettier": "5.2.3",
         "eslint-plugin-promise": "7.2.1",
         "eslint-plugin-sonarjs": "3.0.2",
-        "typescript-eslint": "8.46.2",
         "globals": "16.0.0",
         "husky": "8.0.3",
         "jest": "30.2.0",
@@ -39,6 +38,7 @@
         "rimraf": "6.0.1",
         "ts-jest": "29.4.5",
         "typescript": "5.9.3",
+        "typescript-eslint": "8.46.2",
         "update-ts-references": "3.6.2",
         "yargs-parser": "21.1.1"
     },

packages/eslint-plugin-fiori-tools/config/flat/eslintrc-common.js → packages/eslint-plugin-fiori-tools/config/eslintrc-common.js

@@ -7,8 +7,9 @@ module.exports = defineConfig([
         languageOptions: {
             globals: {
                 ...globals.browser,
-                ...globals.node
+                ...globals.node,
+                'sap': 'readonly'
             }
         }
     }
-]);
+]);

packages/eslint-plugin-fiori-tools/config/eslintrc-prod.js

@@ -0,0 +1,81 @@
+const { defineConfig } = require('eslint/config');
+const babelParser = require('@babel/eslint-parser');
+const js = require('@eslint/js');
+
+module.exports = defineConfig([
+    {
+        files: ['./webapp/**/*.js', './webapp/**/*.ts'],
+
+        ignores: [
+            'target/**',
+            'webapp/test/**',
+            'webapp/localservice/**',
+            'backup/**',
+            '**/Gruntfile.js',
+            '**/changes_preview.js',
+            '**/changes_preview.ts',
+            '**/gulpfile.js',
+            '**/*.d.ts',
+            'test/**'
+        ],
+
+        languageOptions: {
+            parser: babelParser,
+            parserOptions: {
+                requireConfigFile: false
+            }
+        },
+
+        plugins: {
+            '@sap-ux/fiori-tools': require('../lib/index.js')
+        },
+
+        rules: {
+            ...js.configs.recommended.rules,
+            '@sap-ux/fiori-tools/sap-no-global-variable': 'error',
+            '@sap-ux/fiori-tools/sap-no-jquery-device-api': 'warn',
+            '@sap-ux/fiori-tools/sap-no-hardcoded-color': 'error',
+            '@sap-ux/fiori-tools/sap-no-hardcoded-url': 'error',
+            '@sap-ux/fiori-tools/sap-no-localstorage': 'error',
+            '@sap-ux/fiori-tools/sap-no-override-rendering': 'error',
+            '@sap-ux/fiori-tools/sap-no-override-storage-prototype': 'error',
+            '@sap-ux/fiori-tools/sap-no-sessionstorage': 'error',
+            '@sap-ux/fiori-tools/sap-no-ui5base-prop': 'error',
+            '@sap-ux/fiori-tools/sap-message-toast': 'warn',
+            '@sap-ux/fiori-tools/sap-no-ui5-prop-warning': 'warn',
+            '@sap-ux/fiori-tools/sap-no-localhost': 'warn',
+            '@sap-ux/fiori-tools/sap-usage-basemastercontroller': 'warn',
+            '@sap-ux/fiori-tools/sap-no-absolute-component-path': 'error',
+            '@sap-ux/fiori-tools/sap-no-encode-file-service': 'warn',
+            '@sap-ux/fiori-tools/sap-no-dom-insertion': 'warn',
+            '@sap-ux/fiori-tools/sap-cross-application-navigation': 'warn',
+            '@sap-ux/fiori-tools/sap-no-location-usage': 'warn',
+            '@sap-ux/fiori-tools/sap-timeout-usage': 'warn',
+            '@sap-ux/fiori-tools/sap-no-proprietary-browser-api': 'warn',
+            '@sap-ux/fiori-tools/sap-no-dom-access': 'warn',
+            '@sap-ux/fiori-tools/sap-no-history-manipulation': 'warn',
+            '@sap-ux/fiori-tools/sap-no-global-selection': 'warn',
+            '@sap-ux/fiori-tools/sap-no-location-reload': 'error',
+            '@sap-ux/fiori-tools/sap-no-global-event': 'error',
+            '@sap-ux/fiori-tools/sap-no-exec-command': 'error',
+            '@sap-ux/fiori-tools/sap-no-br-on-return': 'error',
+            '@sap-ux/fiori-tools/sap-no-dynamic-style-insertion': 'error',
+            '@sap-ux/fiori-tools/sap-no-element-creation': 'error',
+            '@sap-ux/fiori-tools/sap-no-global-define': 'error',
+            '@sap-ux/fiori-tools/sap-forbidden-window-property': 'warn',
+            '@sap-ux/fiori-tools/sap-no-navigator': 'error',
+            '@sap-ux/fiori-tools/sap-no-inner-html-write': 'error',
+            '@sap-ux/fiori-tools/sap-no-inner-html-access': 'warn',
+            '@sap-ux/fiori-tools/sap-bookmark-performance': 'warn',
+            '@sap-ux/fiori-tools/sap-no-commons-usage': 'error',
+            '@sap-ux/fiori-tools/sap-ui5-no-private-prop': 'off',
+            '@sap-ux/fiori-tools/sap-browser-api-error': 'off',
+            '@sap-ux/fiori-tools/sap-browser-api-warning': 'warn',
+            '@sap-ux/fiori-tools/sap-no-window-alert': 'off',
+            '@sap-ux/fiori-tools/sap-ui5-legacy-jquerysap-usage': 'warn',
+            '@sap-ux/fiori-tools/sap-ui5-global-eval': 'warn',
+            '@sap-ux/fiori-tools/sap-ui5-legacy-factories': 'warn',
+            '@sap-ux/fiori-tools/sap-ui5-forms': 'warn'
+        }
+    }
+]);

packages/eslint-plugin-fiori-tools/config/eslintrc-test.js

@@ -0,0 +1,22 @@
+const { defineConfig } = require('eslint/config');
+const babelParser = require('@babel/eslint-parser');
+
+module.exports = defineConfig([{
+    files: ['webapp/test/**/*.js', 'webapp/test/**/*.ts'],
+    ignores: ['**/*.d.ts'],
+
+    languageOptions: {
+        parser: babelParser,
+        parserOptions: {
+            requireConfigFile: false
+        }
+    },
+
+    plugins: {
+        '@sap-ux/fiori-tools': require('../lib/index.js')
+    },
+
+    rules: {
+        '@sap-ux/fiori-tools/sap-opa5-autowait-true': 'warn'
+    }
+}]);

packages/eslint-plugin-fiori-tools/config/eslintrc-typescript.js

@@ -0,0 +1,51 @@
+const {
+    defineConfig,
+} = require("eslint/config");
+
+const typescriptEslint = require("@typescript-eslint/eslint-plugin");
+const tsParser = require("@typescript-eslint/parser");
+const js = require("@eslint/js");
+const tseslint = require('typescript-eslint');
+
+
+
+module.exports = defineConfig([
+    {
+        files: ["./webapp/*.ts", "./webapp/**/*.ts"],
+
+        ignores: [
+            "target/**",
+            "webapp/test/changes_loader.ts",
+            "webapp/test/changes_preview.ts",
+            "webapp/localservice/**",
+            "webapp/localService/**",
+            "undefined/**/Example.qunit.ts",
+            "backup/**",
+            "**/*.d.ts",
+        ],
+
+        plugins: {
+            "@typescript-eslint": typescriptEslint,
+        },
+
+    languageOptions: {
+        parser: tsParser,
+        ecmaVersion: 5,
+        sourceType: "script",
+
+            parserOptions: {
+                projectService: true,
+            },
+        },
+
+        rules: {
+            ...typescriptEslint.configs.recommended.rules,
+            ...typescriptEslint.configs['recommended-type-checked'].rules,
+            "@typescript-eslint/no-unsafe-call": "warn",
+            "@typescript-eslint/no-unsafe-member-access": "warn",
+            "@typescript-eslint/no-unsafe-return": "warn",
+            "@typescript-eslint/no-unsafe-argument": "warn",
+            "@typescript-eslint/no-unsafe-assignment": "warn",
+        },
+    }
+]);