feat: support manifest schema version 2 #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 11dc487 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Klaus-Keller
approved these changes
Nov 26, 2025
Contributor
Klaus-Keller
left a comment
Klaus-Keller
left a comment
There was a problem hiding this comment.
Thanks @marufrasully!
- my concerns have been addressed
- support for manifest version 2.x.z works
- changeset exists
- test coverage is great
- did a manual test with a build vsix and visual review
Approved from my side
vadson71
approved these changes
Nov 27, 2025
Contributor
vadson71
left a comment
vadson71
left a comment
There was a problem hiding this comment.
Code changes look good
Covered by tests
Didn't test locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
#748
This PR
update:schemato also include v2 schema. Make implementation generic.This diagram illustrate the flow
