Add PermissionRequest schema and API for LED sign access requests

[Embotic-Wayne]

• added mongodb schema for user id, type, and when its deleted (excluding duplicates)
• new api to create, read, and delete permission requests sent by members
• unit tests to validate their behavior

[charred-70]

lgtm w tree

[adarshm11]

is that a banana

[evanugarte]

we can remove this, we have the PermissionRequestSchema.index to take care of this

[evanugarte]

i know they will be a 1 to 1 mapping, we will use the values when we create new data though

Suggested change

	enum: Object.keys(PermissionRequestTypes),
	enum: Object.values(PermissionRequestTypes),

[evanugarte]

instead of { unique: true } can it be

{ 
    unique: true, 
    partialFilterExpression: { deletedAt: null } 
}

that way we dont index deleted records

[evanugarte]

we can also return an empty 200, unless we want to do something with this data in the frontend after submitting

[evanugarte]

we have CONFLICT instead of BAD_REQUEST

we can send that and no text back, since conflict implies something exists

[evanugarte]

how about / returns everything, up to you

[evanugarte]

can we consolidate both endpoints into one /

the endpoint can either take a parameter like userId, or nothing

if we didnt pass any filters in, return everything if the user is an officer or higher

if we passed in a user id, return the data if

• the user is less than an officer and its their own user id.
• the user is an officer or higher

[evanugarte]

sorry how about this

if the user is not an officer, dont listen to any id they send them, and just use decoded.token._id.toString() as what to query for

[evanugarte]

Suggested change

	return res.status(BAD_REQUEST).send({ error: 'Invalid type' });
	return res.status(BAD_REQUEST).send({ error: `${type} is an invalid type, try ${Object.keys(PermissionRequestTypes)}` });

[evanugarte]

lets do this like below, also before this, lets make sure _id is set, and if it isnt, use the decoded.token._id

let idToUse = _id;

if (decoded.token.accessLevel < membershipState.OFFICER) {
  idToUse = decoded.token._id;
}

const query = {
  _id: idToUse,
  type,
  deletedAt: null,
};

const request = await PermissionRequest.findOne({
        userId: decoded.token._id,
        type,
        deletedAt: null,
      });

[evanugarte]

are we sure if no record if found, it returns null? lets add a unit test to /delete to ensure 404 is returned when we search for an _id that doesnt exist

[evanugarte]

Suggested change

	router.get('/get', async (req, res) => {
	router.get('/', async (req, res) => {

[evanugarte]

this should also work

Suggested change

	if (!isOfficer) {
	query.userId = decoded.token._id.toString();
	} else {
	if (queryUserId) {
	query.userId = queryUserId;
	}
	}
	if (queryUserId) {
	query.userId = queryUserId;
	}
	if (!isOfficer) {
	query.userId = decoded.token._id.toString();
	}