Skip to content

Rosa Bulo (REB) SCMSUITE-- SO107 (Zoho-AT1-I138): Removed sympy example#374

Merged
rebadam merged 1 commit intofix2026from
RosaBulo/balance_example
Mar 11, 2026
Merged

Rosa Bulo (REB) SCMSUITE-- SO107 (Zoho-AT1-I138): Removed sympy example#374
rebadam merged 1 commit intofix2026from
RosaBulo/balance_example

Conversation

@rebadam
Copy link
Contributor

@rebadam rebadam commented Mar 11, 2026

Removed sympy example
See Zoho AT1-I138

  1. There are some differences between the sympy and the PLAMS eigenvectors.
    They are equally sparse, but Sympy seems to have more integers, so it looks a litle nicer.
  2. Computing the eigenvectors with sympy is a little slower always
    (probably due to the conversion to a sympy matrix)
  3. With sympy the balancing is sometimes a tiny bit faster
    but this does not outway the loss in the first step.

I now removed the sympy example, but it should stay in the unit tests.

- There are small differences between the native Plams and sympy eigenvectors and timings,
  but indeed, they are not important to the user.
  The option to use sympy is good for unit testing, though.
@rebadam rebadam merged commit 049c602 into fix2026 Mar 11, 2026
21 checks passed
@rebadam rebadam deleted the RosaBulo/balance_example branch March 11, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants