Modernizing packaging to Poetry, and automate publishing to PyPI#13
Modernizing packaging to Poetry, and automate publishing to PyPI#13
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the project's packaging infrastructure by migrating from setuptools to Poetry and implementing automated PyPI publishing. The changes streamline dependency management and enable continuous deployment upon GitHub releases.
- Migration from
setup.pyto Poetry-managedpyproject.tomlconfiguration - Addition of GitHub Actions workflow for automated PyPI publishing on releases
- Updates to pre-commit hook versions and gitignore improvements
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Removed legacy setuptools configuration file |
| setup.cfg | Removed setuptools metadata configuration |
| pyproject.toml | Converted to Poetry configuration with updated dependencies and build system |
| .pre-commit-config.yaml | Updated pre-commit hook versions from v5.0.0 to v6.0.0 and ruff from v0.12.1 to v0.13.1 |
| .github/workflows/pypi_release.yml | Added new GitHub Actions workflow for automated PyPI publishing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mypy.ini
Outdated
| @@ -1,3 +1,3 @@ | |||
| [mypy] | |||
| python_version = "3.9" | |||
| python_version = "3.10" | |||
There was a problem hiding this comment.
@nllong can we make this change now? I think SEED is still on 3.9...
There was a problem hiding this comment.
Shouldn't be too hard to stick with 3.9. The original didn't have any versioning on dependencies, so I just set the current version of everything. I could enforce older versions of dependencies and that way support 3.9 again, though we might give up 3.13 in the process.
nllong
left a comment
There was a problem hiding this comment.
once you make sure that Python 3.9 is supported, then merge!
setup.pytopyproject.tomlmanaged by poetry